From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: xiaopeitux@foxmail.com
Cc: john.g.garry@oracle.com, linux-kernel@vger.kernel.org,
robh@kernel.org, xiaopei01@kylinos.cn, xuwei5@hisilicon.com
Subject: Re: [PATCH 3/3 V2] lib: logic_pio: Add detailed comments for find_io_range() and logic_pio_trans_cpuaddr()
Date: Tue, 22 Apr 2025 18:47:59 +0300 [thread overview]
Message-ID: <aAe6L0GyQO-yXZrE@smile.fi.intel.com> (raw)
In-Reply-To: <tencent_3FA290FB5E6F27C37304AEA91143DC0F5408@qq.com>
On Tue, Apr 22, 2025 at 07:32:19PM +0800, xiaopeitux@foxmail.com wrote:
> From: Pei Xiao <xiaopei01@kylinos.cn>
>
> Add comments that we were previously overlooked for find_io_range()
> and logic_pio_trans_cpuaddr().
You effectively ignored part of my comment. Please, run kernel-doc validator
and see the result. There are missing "Return:" sections. That's what it will
tell you.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-04-22 15:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1745320689.git.xiaopei01@kylinos.cn>
2025-04-22 11:31 ` [PATCH 1/3 V2] bus: hisi_lpc: remove unused head file in hisi_lpc.c xiaopeitux
2025-04-22 15:47 ` Andy Shevchenko
2025-04-23 3:30 ` Pei Xiao
2025-04-22 11:31 ` [PATCH 2/3 V1] lib: logic_pio: export function symbol in logic_pio xiaopeitux
2025-04-22 15:27 ` Andy Shevchenko
2025-04-22 15:30 ` Andy Shevchenko
2025-04-22 16:05 ` John Garry
2025-04-23 3:36 ` Pei Xiao
2025-04-23 7:18 ` John Garry
2025-04-22 11:32 ` [PATCH 3/3 V2] lib: logic_pio: Add detailed comments for find_io_range() and logic_pio_trans_cpuaddr() xiaopeitux
2025-04-22 15:47 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAe6L0GyQO-yXZrE@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=xiaopei01@kylinos.cn \
--cc=xiaopeitux@foxmail.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®