Re: [PATCH 1/3 V2] bus: hisi_lpc: remove unused head file in hisi_lpc.c

[Pei Xiao <xiaopeitux@foxmail.com>]

在 2025/4/22 23:47, Andy Shevchenko 写道:
> On Tue, Apr 22, 2025 at 07:31:22PM +0800, xiaopeitux@foxmail.com wrote:
>> From: Pei Xiao <xiaopei01@kylinos.cn>
>>
>> linux/console.h,linux/pci.h,linux/slab.h
>> are not used, removes it.
> There are more unused and many are missed.
> My diff looks like this:
>
> diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> index 53dd1573e323..4911afdac316 100644
> --- a/drivers/bus/hisi_lpc.c
> +++ b/drivers/bus/hisi_lpc.c
> @@ -7,17 +7,22 @@
>   */
>  
>  #include <linux/acpi.h>
> -#include <linux/console.h>
> +#include <linux/bits.h>
>  #include <linux/delay.h>
> +#include <linux/err.h>
>  #include <linux/io.h>
> +#include <linux/ioport.h>
>  #include <linux/logic_pio.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
> -#include <linux/of.h>
>  #include <linux/of_platform.h>
> -#include <linux/pci.h>
>  #include <linux/platform_device.h>
> +#include <linux/property.h>
>  #include <linux/serial_8250.h>
> -#include <linux/slab.h>
> +#include <linux/spinlock.h>
> +#include <linux/types.h>
> +
> +#include <asm/byteorder.h>

Thanks for you help.

I have send v3 : https://lore.kernel.org/lkml/cover.1745377493.git.xiaopei01@kylinos.cn/

You are such a helpful and technically skilled expert!

Thanks again!

Pei.

>  
>  #define DRV_NAME "hisi-lpc"
>  
>
> ...
>
>>  #include <linux/acpi.h>
>> -#include <linux/console.h>
>>  #include <linux/delay.h>
>>  #include <linux/io.h>
>>  #include <linux/logic_pio.h>
>>  #include <linux/module.h>
>>  #include <linux/of.h>
>>  #include <linux/of_platform.h>
>> -#include <linux/pci.h>
>>  #include <linux/platform_device.h>
>>  #include <linux/serial_8250.h>
>> -#include <linux/slab.h>