From: John Garry <john.g.garry@oracle.com>
To: Pei Xiao <xiaopei01@kylinos.cn>, xiaopeitux@foxmail.com
Cc: andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org,
robh@kernel.org, xuwei5@hisilicon.com
Subject: Re: [PATCH 2/3 V1] lib: logic_pio: export function symbol in logic_pio
Date: Wed, 23 Apr 2025 08:18:17 +0100 [thread overview]
Message-ID: <0c71d318-a7d8-4b40-8721-fa21a7fa806a@oracle.com> (raw)
In-Reply-To: <0c3b4a88-58b7-4088-a4fa-45f927ce0edd@kylinos.cn>
On 23/04/2025 04:36, Pei Xiao wrote:
>
> 在 2025/4/23 00:05, John Garry 写道:
>> On 22/04/2025 12:31, xiaopeitux@foxmail.com wrote:
>>> From: Pei Xiao<xiaopei01@kylinos.cn>
>>>
>>> export some function via EXPORT_SYMBOL, convenient to use in
>>> kernel modules in the future if somebody went to use this lib.
>>> This is one reason for this library exists.
>>>
>>> Signed-off-by: Pei Xiao<xiaopei01@kylinos.cn>
>>
>> No, we don't export just because someone might need this is future.
>>
> Now modify it，Might it be convenient for future people?
>
> People in the future might be able to save some effort here.
No, absolutely not. The reason we don't is because it enables more
out-of-tree rubbish.
>
>> And, FWIW, EXPORT_SYMBOL_GPL is preferred.
next prev parent reply other threads:[~2025-04-23 7:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1745320689.git.xiaopei01@kylinos.cn>
2025-04-22 11:31 ` [PATCH 1/3 V2] bus: hisi_lpc: remove unused head file in hisi_lpc.c xiaopeitux
2025-04-22 15:47 ` Andy Shevchenko
2025-04-23 3:30 ` Pei Xiao
2025-04-22 11:31 ` [PATCH 2/3 V1] lib: logic_pio: export function symbol in logic_pio xiaopeitux
2025-04-22 15:27 ` Andy Shevchenko
2025-04-22 15:30 ` Andy Shevchenko
2025-04-22 16:05 ` John Garry
2025-04-23 3:36 ` Pei Xiao
2025-04-23 7:18 ` John Garry [this message]
2025-04-22 11:32 ` [PATCH 3/3 V2] lib: logic_pio: Add detailed comments for find_io_range() and logic_pio_trans_cpuaddr() xiaopeitux
2025-04-22 15:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c71d318-a7d8-4b40-8721-fa21a7fa806a@oracle.com \
--to=john.g.garry@oracle.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=xiaopei01@kylinos.cn \
--cc=xiaopeitux@foxmail.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®