From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "Sergei Zviagintsev" <sergei@s15v.net>
Cc: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
"'Daniel Mack'" <daniel@zonque.org>,
"'David Herrmann'" <dh.herrmann@googlemail.com>,
"'Djalal Harouni'" <tixxdz@opendz.org>,
"'linux-kernel'" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 10/44] kdbus: Use conditional operator
Date: Fri, 09 Oct 2015 11:58:08 +0800 [thread overview]
Message-ID: <05f501d10246$b5cd9350$2168b9f0$@alibaba-inc.com> (raw)
In-Reply-To: <05f401d10246$1a881ff0$4f985fd0$@alibaba-inc.com>
>
> Signed-off-by: Sergei Zviagintsev <sergei@...v.net>
> ---
> ipc/kdbus/names.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/ipc/kdbus/names.c b/ipc/kdbus/names.c
> index bf44ca3f12b6..6b31b38ac2ad 100644
> --- a/ipc/kdbus/names.c
> +++ b/ipc/kdbus/names.c
> @@ -438,10 +438,7 @@ static void kdbus_name_release_unlocked(struct kdbus_name_owner *owner)
> name->activator = NULL;
>
> if (!primary || owner == primary) {
> - next = kdbus_name_entry_first(name);
> - if (!next)
> - next = name->activator;
> -
> + next = kdbus_name_entry_first(name) ?: name->activator;
Fix? Cleanup? What we gain, given no log message?
> if (next) {
> /* hand to next in queue */
> next->flags &= ~KDBUS_NAME_IN_QUEUE;
> --
> 1.8.3.1
>
>
next parent reply other threads:[~2015-10-09 3:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <05f401d10246$1a881ff0$4f985fd0$@alibaba-inc.com>
2015-10-09 3:58 ` Hillf Danton [this message]
2015-10-08 11:31 [PATCH 00/44] kdbus cleanups Sergei Zviagintsev
2015-10-08 11:31 ` [PATCH 10/44] kdbus: Use conditional operator Sergei Zviagintsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='05f501d10246$b5cd9350$2168b9f0$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=daniel@zonque.org \
--cc=dh.herrmann@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei@s15v.net \
--cc=tixxdz@opendz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®