* Re: [PATCH 10/44] kdbus: Use conditional operator
[not found] <05f401d10246$1a881ff0$4f985fd0$@alibaba-inc.com>
@ 2015-10-09 3:58 ` Hillf Danton
0 siblings, 0 replies; 2+ messages in thread
From: Hillf Danton @ 2015-10-09 3:58 UTC (permalink / raw)
To: Sergei Zviagintsev
Cc: 'Greg Kroah-Hartman', 'Daniel Mack',
'David Herrmann', 'Djalal Harouni',
'linux-kernel'
>
> Signed-off-by: Sergei Zviagintsev <sergei@...v.net>
> ---
> ipc/kdbus/names.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/ipc/kdbus/names.c b/ipc/kdbus/names.c
> index bf44ca3f12b6..6b31b38ac2ad 100644
> --- a/ipc/kdbus/names.c
> +++ b/ipc/kdbus/names.c
> @@ -438,10 +438,7 @@ static void kdbus_name_release_unlocked(struct kdbus_name_owner *owner)
> name->activator = NULL;
>
> if (!primary || owner == primary) {
> - next = kdbus_name_entry_first(name);
> - if (!next)
> - next = name->activator;
> -
> + next = kdbus_name_entry_first(name) ?: name->activator;
Fix? Cleanup? What we gain, given no log message?
> if (next) {
> /* hand to next in queue */
> next->flags &= ~KDBUS_NAME_IN_QUEUE;
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 10/44] kdbus: Use conditional operator
2015-10-08 11:31 [PATCH 00/44] kdbus cleanups Sergei Zviagintsev
@ 2015-10-08 11:31 ` Sergei Zviagintsev
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Zviagintsev @ 2015-10-08 11:31 UTC (permalink / raw)
To: Greg Kroah-Hartman, Daniel Mack, David Herrmann, Djalal Harouni
Cc: linux-kernel, Sergei Zviagintsev
Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
---
ipc/kdbus/names.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/ipc/kdbus/names.c b/ipc/kdbus/names.c
index bf44ca3f12b6..6b31b38ac2ad 100644
--- a/ipc/kdbus/names.c
+++ b/ipc/kdbus/names.c
@@ -438,10 +438,7 @@ static void kdbus_name_release_unlocked(struct kdbus_name_owner *owner)
name->activator = NULL;
if (!primary || owner == primary) {
- next = kdbus_name_entry_first(name);
- if (!next)
- next = name->activator;
-
+ next = kdbus_name_entry_first(name) ?: name->activator;
if (next) {
/* hand to next in queue */
next->flags &= ~KDBUS_NAME_IN_QUEUE;
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-09 3:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <05f401d10246$1a881ff0$4f985fd0$@alibaba-inc.com>
2015-10-09 3:58 ` [PATCH 10/44] kdbus: Use conditional operator Hillf Danton
2015-10-08 11:31 [PATCH 00/44] kdbus cleanups Sergei Zviagintsev
2015-10-08 11:31 ` [PATCH 10/44] kdbus: Use conditional operator Sergei Zviagintsev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®