Re: [PATCH v3 09/17] media: i2c: os05b10: update pixel rate on 10/12-bit mode switch

[Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>]

On 7/18/26 23:09, Tarang Raval wrote:
> After adding 12-bit RAW support, the pixel rate depends on the selected
> mode bpp. Store the V4L2_CID_PIXEL_RATE control pointer and update its
> range/value when the mode changes so 10/12-bit switching reports the
> correct pixel rate.
> 
> Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io>
> ---
>   drivers/media/i2c/os05b10.c | 41 ++++++++++++++++++++++++-------------
>   1 file changed, 27 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c
> index e11a3c308299..3fd788bd8b20 100644
> --- a/drivers/media/i2c/os05b10.c
> +++ b/drivers/media/i2c/os05b10.c
> @@ -473,6 +473,7 @@ struct os05b10 {
>   	/* V4L2 Controls */
>   	struct v4l2_ctrl_handler handler;
>   	struct v4l2_ctrl *link_freq;
> +	struct v4l2_ctrl *pixel_rate;
>   	struct v4l2_ctrl *hblank;
>   	struct v4l2_ctrl *vblank;
>   	struct v4l2_ctrl *gain;
> @@ -704,12 +705,35 @@ static int os05b10_enum_mbus_code(struct v4l2_subdev *sd,
>   	return 0;
>   }
>   
> +static u64 os05b10_pixel_rate(struct os05b10 *os05b10,
> +			      const struct os05b10_mode *mode)
> +{
> +	u64 link_freq = link_frequencies[os05b10->link_freq_index];
> +	u64 pixel_rate = div_u64(link_freq * 2 * os05b10->data_lanes, mode->bpp);
> +
> +	dev_dbg(os05b10->dev,
> +		"link_freq=%llu bpp=%u lanes=%u pixel_rate=%llu\n",
> +		link_freq, mode->bpp, os05b10->data_lanes, pixel_rate);
> +
> +	return pixel_rate;
> +}
> +
>   static int os05b10_set_framing_limits(struct os05b10 *os05b10,
>   				      const struct os05b10_mode *mode)
>   {
> +	u64 pixel_rate = os05b10_pixel_rate(os05b10, mode);
>   	u32 hblank, vblank, vblank_max, max_exp;
>   	int ret;
>   
> +	ret = __v4l2_ctrl_modify_range(os05b10->pixel_rate, pixel_rate,
> +				       pixel_rate, 1, pixel_rate);
> +	if (ret)
> +		return ret;
> +
> +	ret = __v4l2_ctrl_s_ctrl_int64(os05b10->pixel_rate, pixel_rate);
> +	if (ret)
> +		return ret;
> +
>   	hblank = mode->hts - mode->width;
>   	ret = __v4l2_ctrl_modify_range(os05b10->hblank, hblank, hblank, 1,
>   				       hblank);
> @@ -1070,18 +1094,6 @@ static int os05b10_parse_endpoint(struct os05b10 *os05b10)
>   	return ret;
>   }
>   
> -static u64 os05b10_pixel_rate(struct os05b10 *os05b10,
> -			      const struct os05b10_mode *mode)
> -{
> -	u64 link_freq = link_frequencies[os05b10->link_freq_index];
> -	u64 pixel_rate = div_u64(link_freq * 2 * os05b10->data_lanes, mode->bpp);
> -
> -	dev_dbg(os05b10->dev,
> -		"link_freq=%llu bpp=%u lanes=%u pixel_rate=%llu\n",
> -		link_freq, mode->bpp, os05b10->data_lanes, pixel_rate);
> -
> -	return pixel_rate;
> -}
>   
>   static int os05b10_init_controls(struct os05b10 *os05b10)
>   {
> @@ -1095,8 +1107,9 @@ static int os05b10_init_controls(struct os05b10 *os05b10)
>   	v4l2_ctrl_handler_init(ctrl_hdlr, 12);
>   
>   	pixel_rate = os05b10_pixel_rate(os05b10, mode);
> -	v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops, V4L2_CID_PIXEL_RATE,
> -			  pixel_rate, pixel_rate, 1, pixel_rate);
> +	os05b10->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops,
> +						V4L2_CID_PIXEL_RATE, pixel_rate,
> +						pixel_rate, 1, pixel_rate);
>   
>   	os05b10->link_freq = v4l2_ctrl_new_int_menu(ctrl_hdlr, &os05b10_ctrl_ops,
>   						    V4L2_CID_LINK_FREQ,

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

-- 
Best wishes,
Vladimir