mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
To: Tarang Raval <tarang.raval@siliconsignals.io>,
	sakari.ailus@linux.intel.com, mehdi.djait@linux.intel.com
Cc: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>,
	Elgin Perumbilly <elgin.perumbilly@siliconsignals.io>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil+cisco@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 11/17] media: i2c: os05b10: keep vblank and exposure range in sync on mode switch
Date: Sat, 25 Jul 2026 10:30:02 +0300	[thread overview]
Message-ID: <b97ae9a9-6473-4004-8368-fd5ebef63897@linaro.org> (raw)
In-Reply-To: <20260718200912.16001-12-tarang.raval@siliconsignals.io>

On 7/18/26 23:09, Tarang Raval wrote:
> Update vblank through the control path on mode changes so exposure
> limits and default values are recalculated consistently from the
> active mode.
> 
> Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io>
> ---
>   drivers/media/i2c/os05b10.c | 19 +++++++++++++------
>   1 file changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c
> index c54b466656aa..d124db74766c 100644
> --- a/drivers/media/i2c/os05b10.c
> +++ b/drivers/media/i2c/os05b10.c
> @@ -745,13 +745,23 @@ static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl)
>   {
>   	struct os05b10 *os05b10 = container_of_const(ctrl->handler,
>   						     struct os05b10, handler);
> +	const struct os05b10_mode *mode_list;
>   	struct v4l2_subdev_state *state;
> +	const struct os05b10_mode *mode;
>   	struct v4l2_mbus_framefmt *fmt;
> +	unsigned int num_modes;
>   	int vmax, ret;
>   
>   	state = v4l2_subdev_get_locked_active_state(&os05b10->sd);
>   	fmt = v4l2_subdev_state_get_format(state, 0);
>   
> +	ret = get_mode_table(os05b10, fmt->code, &mode_list, &num_modes);
> +	if (ret)
> +		return ret;
> +
> +	mode = v4l2_find_nearest_size(mode_list, num_modes, width, height,
> +				      fmt->width, fmt->height);
> +
>   	if (ctrl->id == V4L2_CID_VBLANK) {
>   		/* Honour the VBLANK limits when setting exposure. */
>   		s64 max = fmt->height + ctrl->val - OS05B10_EXPOSURE_MARGIN;
> @@ -759,7 +769,7 @@ static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl)
>   		ret = __v4l2_ctrl_modify_range(os05b10->exposure,
>   					       os05b10->exposure->minimum, max,
>   					       os05b10->exposure->step,
> -					       os05b10->exposure->default_value);
> +					       mode->exp);
>   		if (ret)
>   			return ret;
>   	}
> @@ -842,7 +852,7 @@ static int os05b10_set_framing_limits(struct os05b10 *os05b10,
>   				      const struct os05b10_mode *mode)
>   {
>   	u64 pixel_rate = os05b10_pixel_rate(os05b10, mode);
> -	u32 hblank, vblank, vblank_max, max_exp;
> +	u32 hblank, vblank, vblank_max;
>   	int ret;
>   
>   	ret = __v4l2_ctrl_modify_range(os05b10->pixel_rate, pixel_rate,
> @@ -867,10 +877,7 @@ static int os05b10_set_framing_limits(struct os05b10 *os05b10,
>   	if (ret)
>   		return ret;
>   
> -	max_exp = mode->vts - OS05B10_EXPOSURE_MARGIN;
> -	return __v4l2_ctrl_modify_range(os05b10->exposure,
> -					OS05B10_EXPOSURE_MIN, max_exp,
> -					OS05B10_EXPOSURE_STEP, mode->exp);
> +	return __v4l2_ctrl_s_ctrl(os05b10->vblank, vblank);
>   }
>   
>   static int os05b10_set_pad_format(struct v4l2_subdev *sd,

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

-- 
Best wishes,
Vladimir

  reply	other threads:[~2026-07-25  7:30 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18 20:08 [PATCH v3 00/17] media: i2c: os05b10: Refactor driver and Add new features Tarang Raval
2026-07-18 20:08 ` [PATCH v3 01/17] media: i2c: os05b10: Use pm_runtime_get_if_active() when applying controls Tarang Raval
2026-07-22  5:58   ` Jai Luthra
2026-07-24  6:47     ` Tarang Raval
2026-07-18 20:08 ` [PATCH v3 02/17] media: i2c: os05b10: drop unused group-hold programming Tarang Raval
2026-07-18 20:08 ` [PATCH v3 03/17] media: i2c: os05b10: add register definitions and use them in init table Tarang Raval
2026-07-21 17:25   ` Mehdi Djait
2026-07-24 13:09   ` Vladimir Zapolskiy
2026-07-18 20:08 ` [PATCH v3 04/17] media: i2c: os05b10: split common and mode-specific init registers Tarang Raval
2026-07-21 17:40   ` Mehdi Djait
2026-07-24 13:15   ` Vladimir Zapolskiy
2026-07-18 20:08 ` [PATCH v3 05/17] media: i2c: os05b10: add V4L2 digital gain control Tarang Raval
2026-07-24 13:19   ` Vladimir Zapolskiy
2026-07-24 14:15     ` Tarang Raval
2026-07-18 20:08 ` [PATCH v3 06/17] media: i2c: os05b10: Add H/V flip support Tarang Raval
2026-07-21 17:43   ` Mehdi Djait
2026-07-22  5:51   ` Jai Luthra
2026-07-24  7:01     ` Tarang Raval
2026-07-24 13:27   ` Vladimir Zapolskiy
2026-07-18 20:08 ` [PATCH v3 07/17] media: i2c: os05b10: Add test pattern options Tarang Raval
2026-07-21 17:50   ` Mehdi Djait
2026-07-24 13:43   ` Vladimir Zapolskiy
2026-07-18 20:08 ` [PATCH v3 08/17] media: i2c: os05b10: add 12-bit RAW mode support Tarang Raval
2026-07-24 14:08   ` Vladimir Zapolskiy
2026-07-24 14:30     ` Tarang Raval
2026-07-24 15:03       ` Vladimir Zapolskiy
2026-07-18 20:09 ` [PATCH v3 09/17] media: i2c: os05b10: update pixel rate on 10/12-bit mode switch Tarang Raval
2026-07-22  6:17   ` Jai Luthra
2026-07-22  6:19     ` Jai Luthra
2026-07-24  9:08       ` Tarang Raval
2026-07-25  7:26   ` Vladimir Zapolskiy
2026-07-18 20:09 ` [PATCH v3 10/17] media: i2c: os05b10: Add 1080p and 2x2 binning 720p modes Tarang Raval
2026-07-22  6:05   ` Jai Luthra
2026-07-24  6:44     ` Tarang Raval
2026-07-18 20:09 ` [PATCH v3 11/17] media: i2c: os05b10: keep vblank and exposure range in sync on mode switch Tarang Raval
2026-07-25  7:30   ` Vladimir Zapolskiy [this message]
2026-07-18 20:09 ` [PATCH v3 12/17] media: i2c: os05b10: Update active format before adjusting framing controls Tarang Raval
2026-07-25  7:32   ` Vladimir Zapolskiy
2026-07-18 20:09 ` [PATCH v3 13/17] media: i2c: os05b10: Rename vmax variable in VBLANK control Tarang Raval
2026-07-25  7:33   ` Vladimir Zapolskiy
2026-07-18 20:09 ` [PATCH v3 14/17] media: i2c: os05b10: add 2-lane support Tarang Raval
2026-07-25  7:38   ` Vladimir Zapolskiy
2026-07-18 20:09 ` [PATCH v3 15/17] media: i2c: os05b10: fix negative hblank calculation Tarang Raval
2026-07-22  6:14   ` Jai Luthra
2026-07-24  8:14     ` Tarang Raval
2026-07-18 20:09 ` [PATCH v3 16/17] media: i2c: os05b10: Enable runtime PM autosuspend Tarang Raval
2026-07-22  6:08   ` Jai Luthra
2026-07-24  7:02     ` Tarang Raval
2026-07-24  9:58       ` Jai Luthra
2026-07-18 20:09 ` [PATCH v3 17/17] media: i2c: os05b10: remove unused control fields, simplify error handling Tarang Raval
2026-07-25 11:33   ` Vladimir Zapolskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b97ae9a9-6473-4004-8368-fd5ebef63897@linaro.org \
    --to=vladimir.zapolskiy@linaro.org \
    --cc=elgin.perumbilly@siliconsignals.io \
    --cc=himanshu.bhavani@siliconsignals.io \
    --cc=hverkuil+cisco@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mehdi.djait@linux.intel.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tarang.raval@siliconsignals.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®