Re: [PATCH v5 0/8] Enable video decoder & encoder for MT8189

["Kyrie Wu (吴晗)" <Kyrie.Wu@mediatek.com>]

On Thu, 2025-11-06 at 09:18 -0500, Nicolas Dufresne wrote:
> Hi,
> 
> Le jeudi 06 novembre 2025 à 14:13 +0800, Kyrie Wu a écrit :
> > This series have the follow changing:
> > Firstly add mt8189 video decoder compatible, profile and level to
> > support
> > MT8189 kernel driver.
> > Secondly fix some bugs, including vp 4K profile2 and media device
> > node
> > number bug.
> > Lastly, add mt8189 video encoder compatible.
> > 
> > This series has been tested with MT8189 tast test.
> > Encoding and decoding worked for this chip.
> > 
> > Patches 1-2 Add decoder compatible.
> > Patches 3 Add profile and level supporting.
> > Patches 4 Add core-only VP9 decoding supporting.
> > Patches 5-6 fix some bugs.
> > Patches 7-8 Adds encoder compatible.
> > 
> > ---
> > H264 test results:
> > ./fluster.py run -d GStreamer-H.264-V4L2SL-Gst1.0 -j2 -t 90
> >     JVT-AVC_V1	Ran 96/135 tests successfully
> > 
> > VP9 test results:
> > ./fluster.py run -d GStreamer-VP9-V4L2SL-Gst1.0 -j2 -t 90
> > 	VP9-TEST-VECTORS	Ran 276/305 tests successfully
> > 
> > v4l2-compliance test results:
> > Compliance test for mtk-vcodec-enc device /dev/video2:
> > Total for mtk-vcodec-enc device /dev/video2: 47, Succeeded: 46,
> > Failed: 1, Warnings: 0
> 
> There is one fail, can you explain it ?
> 
> Nicolas

Dear Nicolas,

The failure is caused by subscribed event/dqevent. Our encoder driver
didn't register those apis, which caused this failure.
Here is the fail log, which is samed as MT8196:

https://patchwork.linuxtv.org/project/linux-media/cover/20250528063633.14054-1-irui.wang@mediatek.com/

Control ioctls:
        test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
        test VIDIOC_QUERYCTRL: OK
        test VIDIOC_G/S_CTRL: OK
        test VIDIOC_G/S/TRY_EXT_CTRLS: OK
                fail: v4l2-test-controls.cpp(1171): node->codec_mask &
STATEFUL_ENCODER
        test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: FAIL
        test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
        Standard Controls: 16 Private Controls: 0

Thanks.

Regards,
Kyrie.

> 
> > Compliance test for mtk-vcodec-dec device /dev/video3:
> > Total for mtk-vcodec-dec device /dev/video3: 48, Succeeded: 48,
> > Failed: 0, Warnings: 0
> > 
> > scp upstream link:
> > 
https://patchwork.kernel.org/project/linux-mediatek/patch/20250811015922.32680-1-huayu.zong@mediatek.com/
> > dtsi upstream link:
> > 
https://lore.kernel.org/linux-mediatek/20251030134541.784011-12-jh.hsu@mediatek.com/T/#m847e35de0a5b18fac0ca0624a8559d84964ad5c7
> > 
> > Changes compared with v4:
> > --update H264 & vp9 fluster test results
> > --update vp9 single core decoder prob size setting and commit
> > messages
> > 
> > Changes compared with v3:
> > --add reviewer to commit messages
> > --Rebased on top of the latest media tree
> > 
> > Changes compared with v2:
> > --add H264 fluster test results
> > --reorder compatible string for dt-bindings
> > 
> > Changes compared with v1:
> > --add v4l2-compliance test results
> > --add scp upstream link
> > --add HW difference discriptions for dt-bindings commit messages
> > 
> > This series patches dependent on:
> > [1]
> > 
https://patchwork.linuxtv.org/project/linux-media/cover/20250510075357.11761-1-yunfei.dong@mediatek.com/
> > [2]
> > 
https://patchwork.linuxtv.org/project/linux-media/cover/20250814085642.17343-1-kyrie.wu@mediatek.com/
> > 
> > Kyrie Wu (8):
> >   dt-bindings: media: mediatek: decoder: Add MT8189
> >     mediatek,vcodec-decoder
> >   media: mediatek: vcodec: add decoder compatible to support MT8189
> >   media: mediatek: vcodec: add profile and level supporting for
> > MT8189
> >   media: mediatek: vcodec: Add single core VP9 decoding support for
> >     MT8189
> >   media: mediatek: vcodec: fix vp9 4096x2176 fail for profile2
> >   media: mediatek: vcodec: fix media device node number
> >   dt-bindings: media: Add MT8189 mediatek,vcodec-encoder
> >   media: mediatek: encoder: Add MT8189 encoder compatible data
> > 
> >  .../media/mediatek,vcodec-encoder.yaml        |  2 +
> >  .../media/mediatek,vcodec-subdev-decoder.yaml |  5 +-
> >  .../vcodec/decoder/mtk_vcodec_dec_drv.c       |  9 +++-
> >  .../vcodec/decoder/mtk_vcodec_dec_drv.h       |  1 +
> >  .../vcodec/decoder/mtk_vcodec_dec_stateless.c |  4 ++
> >  .../vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 48 ++++++++++++++-
> > ----
> >  .../vcodec/encoder/mtk_vcodec_enc_drv.c       | 14 ++++++
> >  7 files changed, 68 insertions(+), 15 deletions(-)