Re: [PATCH v5 3/8] media: mediatek: vcodec: add profile and level supporting for MT8189

[Nicolas Dufresne <nicolas.dufresne@collabora.com>]

[-- Attachment #1: Type: text/plain, Size: 2146 bytes --]

Hi,

Le jeudi 06 novembre 2025 à 14:13 +0800, Kyrie Wu a écrit :
> add profile and level supporting for H264 and vp9 of MT8189
> 
> Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c        | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
> index c1cef78471a9..0a9bdc5316f9 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
> @@ -552,6 +552,7 @@ static void mtk_vcodec_dec_fill_h264_level(struct v4l2_ctrl_config *cfg,
>  	switch (ctx->dev->chip_name) {
>  	case MTK_VDEC_MT8192:
>  	case MTK_VDEC_MT8188:
> +	case MTK_VDEC_MT8189:
>  		cfg->max = V4L2_MPEG_VIDEO_H264_LEVEL_5_2;

Please consider my suggestion in 2/8, you could then move all of this into the
static compatible data structure.

Nicolas

>  		break;
>  	case MTK_VDEC_MT8195:
> @@ -573,6 +574,7 @@ static void mtk_vcodec_dec_fill_h264_profile(struct v4l2_ctrl_config *cfg,
>  {
>  	switch (ctx->dev->chip_name) {
>  	case MTK_VDEC_MT8188:
> +	case MTK_VDEC_MT8189:
>  	case MTK_VDEC_MT8195:
>  	case MTK_VDEC_MT8196:
>  		cfg->max = V4L2_MPEG_VIDEO_H264_PROFILE_HIGH_10;
> @@ -623,6 +625,7 @@ static void mtk_vcodec_dec_fill_vp9_level(struct v4l2_ctrl_config *cfg,
>  	case MTK_VDEC_MT8188:
>  		cfg->max = V4L2_MPEG_VIDEO_VP9_LEVEL_5_1;
>  		break;
> +	case MTK_VDEC_MT8189:
>  	case MTK_VDEC_MT8195:
>  	case MTK_VDEC_MT8196:
>  		cfg->max = V4L2_MPEG_VIDEO_VP9_LEVEL_5_2;
> @@ -641,6 +644,7 @@ static void mtk_vcodec_dec_fill_vp9_profile(struct v4l2_ctrl_config *cfg,
>  {
>  	switch (ctx->dev->chip_name) {
>  	case MTK_VDEC_MT8188:
> +	case MTK_VDEC_MT8189:
>  	case MTK_VDEC_MT8195:
>  	case MTK_VDEC_MT8196:
>  		cfg->max = V4L2_MPEG_VIDEO_VP9_PROFILE_2;

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]