Re: [PATCH v5 8/8] media: mediatek: encoder: Add MT8189 encoder compatible data

["Kyrie Wu (吴晗)" <Kyrie.Wu@mediatek.com>]

On Thu, 2025-11-06 at 09:50 -0500, Nicolas Dufresne wrote:
> Le jeudi 06 novembre 2025 à 14:13 +0800, Kyrie Wu a écrit :
> > add compatible data to support MT8189 encoding.
> 
> Don't copy your subject, briefly describe the configuration instead.
> 
> Nicolas
> 
Dear Nicolas,

Thanks for your reminding, I will fix the subject and commit messages
in the coming version.

Thanks.

Regards,
Kyrie
> > 
> > Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@collabora.com>
> > ---
> >  .../mediatek/vcodec/encoder/mtk_vcodec_enc_drv.c   | 14
> > ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git
> > a/drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv
> > .c
> > b/drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv
> > .c
> > index 6b3d2e72fad9..2cc92a8f7a0d 100644
> > ---
> > a/drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv
> > .c
> > +++
> > b/drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv
> > .c
> > @@ -467,6 +467,19 @@ static const struct mtk_vcodec_enc_pdata
> > mt8196_pdata = {
> >  	.set_dma_bit_mask = true,
> >  };
> >  
> > +static const struct mtk_vcodec_enc_pdata mt8189_pdata = {
> > +	.venc_model_num = 8189,
> > +	.capture_formats = mtk_video_formats_capture_h264,
> > +	.num_capture_formats =
> > ARRAY_SIZE(mtk_video_formats_capture_h264),
> > +	.output_formats = mtk_video_formats_output,
> > +	.num_output_formats = ARRAY_SIZE(mtk_video_formats_output),
> > +	.min_bitrate = 64,
> > +	.max_bitrate = 100000000,
> > +	.core_id = VENC_SYS,
> > +	.uses_common_fw_iface = true,
> > +	.set_dma_bit_mask = true,
> > +};
> > +
> >  static const struct of_device_id mtk_vcodec_enc_match[] = {
> >  	{.compatible = "mediatek,mt8173-vcodec-enc",
> >  			.data = &mt8173_avc_pdata},
> > @@ -477,6 +490,7 @@ static const struct of_device_id
> > mtk_vcodec_enc_match[] =
> > {
> >  	{.compatible = "mediatek,mt8192-vcodec-enc", .data =
> > &mt8192_pdata},
> >  	{.compatible = "mediatek,mt8195-vcodec-enc", .data =
> > &mt8195_pdata},
> >  	{.compatible = "mediatek,mt8196-vcodec-enc", .data =
> > &mt8196_pdata},
> > +	{.compatible = "mediatek,mt8189-vcodec-enc", .data =
> > &mt8189_pdata},
> >  	{},
> >  };
> >  MODULE_DEVICE_TABLE(of, mtk_vcodec_enc_match);