mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Kyrie Wu <kyrie.wu@mediatek.com>,
	Tiffany Lin <tiffany.lin@mediatek.com>,
	 Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	Yunfei Dong <yunfei.dong@mediatek.com>,
	Mauro Carvalho Chehab	 <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski	 <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger	 <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno	
	<angelogioacchino.delregno@collabora.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	 Nathan Hebert <nhebert@chromium.org>,
	Arnd Bergmann <arnd@arndb.de>, Irui Wang <irui.wang@mediatek.com>,
	 George Sun <george.sun@mediatek.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
		linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
		linux-mediatek@lists.infradead.org,
	Yilong Zhou <yilong.zhou@mediatek.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
Subject: Re: [PATCH v5 6/8] media: mediatek: vcodec: fix media device node number
Date: Thu, 06 Nov 2025 09:47:58 -0500	[thread overview]
Message-ID: <b5daa900a1af6f379d5fb9757d2712102ca0fc51.camel@collabora.com> (raw)
In-Reply-To: <20251106061323.2193-7-kyrie.wu@mediatek.com>

[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]

Hi,

fix -> Fix

Le jeudi 06 novembre 2025 à 14:13 +0800, Kyrie Wu a écrit :
> change media register device node number to a correct value

You already say that in the subject, the description should explain why vfd_dec-
>minor was wrong.

Nicolas
	

> 
> Fixes: 41f03c673cb7b ("media: mediatek: vcodec: replace pr_* with dev_* for
> v4l2 debug message")
> 
> Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
> ---
>  .../platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c      | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git
> a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c
> b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c
> index fca60e81e3c7..f3e49597602a 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c
> @@ -516,7 +516,8 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
>  			goto err_media_reg;
>  		}
>  
> -		dev_dbg(&pdev->dev, "media registered as /dev/media%d",
> vfd_dec->minor);
> +		dev_dbg(&pdev->dev, "media registered as /dev/media%d",
> +			dev->mdev_dec.devnode->minor);
>  	}
>  
>  	mtk_vcodec_dbgfs_init(dev, false);

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2025-11-06 14:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-06  6:13 [PATCH v5 0/8] Enable video decoder & encoder for MT8189 Kyrie Wu
2025-11-06  6:13 ` [PATCH v5 1/8] dt-bindings: media: mediatek: decoder: Add MT8189 mediatek,vcodec-decoder Kyrie Wu
2025-11-06  6:13 ` [PATCH v5 2/8] media: mediatek: vcodec: add decoder compatible to support MT8189 Kyrie Wu
2025-11-06 14:21   ` Nicolas Dufresne
2025-11-18  7:22     ` Kyrie Wu (吴晗)
2025-11-06  6:13 ` [PATCH v5 3/8] media: mediatek: vcodec: add profile and level supporting for MT8189 Kyrie Wu
2025-11-06 14:23   ` Nicolas Dufresne
2025-11-06  6:13 ` [PATCH v5 4/8] media: mediatek: vcodec: Add single core VP9 decoding support " Kyrie Wu
2025-11-06 14:29   ` Nicolas Dufresne
2025-11-17  7:40     ` Kyrie Wu (吴晗)
2025-11-06  6:13 ` [PATCH v5 5/8] media: mediatek: vcodec: fix vp9 4096x2176 fail for profile2 Kyrie Wu
2025-11-06 14:46   ` Nicolas Dufresne
2025-11-17  7:53     ` Kyrie Wu (吴晗)
2025-11-06 15:17   ` Nicolas Dufresne
2025-11-17  7:36     ` Kyrie Wu (吴晗)
2025-11-17 13:50       ` Nicolas Dufresne
2025-11-06  6:13 ` [PATCH v5 6/8] media: mediatek: vcodec: fix media device node number Kyrie Wu
2025-11-06 14:47   ` Nicolas Dufresne [this message]
2025-11-17  6:15     ` Kyrie Wu (吴晗)
2025-11-06  6:13 ` [PATCH v5 7/8] dt-bindings: media: Add MT8189 mediatek,vcodec-encoder Kyrie Wu
2025-11-06  6:13 ` [PATCH v5 8/8] media: mediatek: encoder: Add MT8189 encoder compatible data Kyrie Wu
2025-11-06 14:50   ` Nicolas Dufresne
2025-11-17  6:14     ` Kyrie Wu (吴晗)
2025-11-06 14:18 ` [PATCH v5 0/8] Enable video decoder & encoder for MT8189 Nicolas Dufresne
2025-11-10  2:32   ` Kyrie Wu (吴晗)
2025-11-10 13:57     ` Nicolas Dufresne
2025-11-17  6:12       ` Kyrie Wu (吴晗)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5daa900a1af6f379d5fb9757d2712102ca0fc51.camel@collabora.com \
    --to=nicolas.dufresne@collabora.com \
    --cc=andrew-ct.chen@mediatek.com \
    --cc=andrzejtp2010@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=arnd@arndb.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=george.sun@mediatek.com \
    --cc=hverkuil@xs4all.nl \
    --cc=irui.wang@mediatek.com \
    --cc=krzk+dt@kernel.org \
    --cc=kyrie.wu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=nhebert@chromium.org \
    --cc=robh@kernel.org \
    --cc=tiffany.lin@mediatek.com \
    --cc=yilong.zhou@mediatek.com \
    --cc=yunfei.dong@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®