From: Andrew Lunn <andrew@lunn.ch>
To: Michael Dege <michael.dege@renesas.com>
Cc: "Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Paul Barker" <paul@pbarker.dev>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Nikita Yushchenko" <nikita.yoush@cogentembedded.com>
Subject: Re: [PATCH 2/3] net: renesas: rswitch: add offloading for L2 switching
Date: Mon, 7 Jul 2025 13:30:45 +0200 [thread overview]
Message-ID: <0be928fc-0fa0-4a62-9819-87e751822fe4@lunn.ch> (raw)
In-Reply-To: <TY4PR01MB14282FF28B33F6A0EAD5251F8824FA@TY4PR01MB14282.jpnprd01.prod.outlook.com>
> > Are these actually needed? It seems like they could be local functions.
>
> Currently is_rdev() is only used in rswitch_l2.c. I moved it to that file and made it static. In the
> future it will also be used in the L3 routing. The function rswitch_modify() is used in rswitch_main.c
> and rswitch_l2.c I believe in this case it does make sense to have a single implementation. Or should
> I use two local copies?
Have long do you think it will be before L3 is added? If you have the
code ready and waiting, then please keep it driver global. If it is
going to be a while before L3 is added, i would add it to
rswitch_l2.c, and move it to a common file when you add rswitch_l3.c
Andrew
next prev parent reply other threads:[~2025-07-07 11:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 5:51 [PATCH 0/3] net: renesas: rswitch: R-Car S4 add HW offloading for layer 2 switching Michael Dege
2025-07-04 5:51 ` [PATCH 1/3] net: renesas: rswitch: rename rswitch.c to rswitch_main.c Michael Dege
2025-07-04 8:34 ` Andrew Lunn
2025-07-04 9:11 ` Niklas Söderlund
2025-07-04 5:51 ` [PATCH 2/3] net: renesas: rswitch: add offloading for L2 switching Michael Dege
2025-07-04 8:43 ` Andrew Lunn
2025-07-04 9:02 ` Nikita Yushchenko
2025-07-04 17:49 ` Andrew Lunn
2025-07-07 8:13 ` Michael Dege
2025-07-07 8:42 ` Michael Dege
2025-07-07 11:30 ` Andrew Lunn [this message]
2025-07-04 5:51 ` [PATCH 3/3] net: renesas: rswitch: add modifiable ageing time Michael Dege
2025-07-07 12:50 ` Geert Uytterhoeven
2025-07-07 12:59 ` Michael Dege
2025-07-04 8:33 ` [PATCH 0/3] net: renesas: rswitch: R-Car S4 add HW offloading for layer 2 switching Andrew Lunn
2025-07-07 10:41 ` Michael Dege
2025-07-07 11:53 ` Andrew Lunn
2025-07-07 12:25 ` Michael Dege
2025-07-04 8:46 ` Andrew Lunn
2025-07-04 9:05 ` Nikita Yushchenko
2025-07-04 17:53 ` Andrew Lunn
2025-07-04 17:56 ` Nikita Yushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0be928fc-0fa0-4a62-9819-87e751822fe4@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=michael.dege@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=paul@pbarker.dev \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®