From: Andrew Lunn <andrew@lunn.ch>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: "Michael Dege" <michael.dege@renesas.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Paul Barker" <paul@pbarker.dev>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] net: renesas: rswitch: R-Car S4 add HW offloading for layer 2 switching
Date: Fri, 4 Jul 2025 19:53:08 +0200 [thread overview]
Message-ID: <27047e61-8307-472d-96dd-1e5b89dc427f@lunn.ch> (raw)
In-Reply-To: <79a57427-fd4a-4b9a-a081-cf09b649a20e@cogentembedded.com>
On Fri, Jul 04, 2025 at 11:05:14AM +0200, Nikita Yushchenko wrote:
> > Looking at the code, it is not clear to me what would happen with:
> >
> > ip link add name br0 type bridge
> > ip link set dev tsn0 master br0
> > ip link set dev br0 up
> > ip link set dev tsn0 up
> > ip link add name br1 type bridge
> > ip link set dev tsn1 master br1
> > ip link set dev br1 up
> > ip link set dev tsn1 up
>
> Per design, it shall enable hardware forwarding when two ports are in the same brdev.
So in this case, the hardware offload has been reserved by br0, but is
in fact never used, since there is only one port in the bridge. If i
was to then do
ip link set dev tsn2 master br1
ip link set dev tsn2 up
br1 would not be offloaded, but done in software.
Andrew
next prev parent reply other threads:[~2025-07-04 17:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 5:51 Michael Dege
2025-07-04 5:51 ` [PATCH 1/3] net: renesas: rswitch: rename rswitch.c to rswitch_main.c Michael Dege
2025-07-04 8:34 ` Andrew Lunn
2025-07-04 9:11 ` Niklas Söderlund
2025-07-04 5:51 ` [PATCH 2/3] net: renesas: rswitch: add offloading for L2 switching Michael Dege
2025-07-04 8:43 ` Andrew Lunn
2025-07-04 9:02 ` Nikita Yushchenko
2025-07-04 17:49 ` Andrew Lunn
2025-07-07 8:13 ` Michael Dege
2025-07-07 8:42 ` Michael Dege
2025-07-07 11:30 ` Andrew Lunn
2025-07-04 5:51 ` [PATCH 3/3] net: renesas: rswitch: add modifiable ageing time Michael Dege
2025-07-07 12:50 ` Geert Uytterhoeven
2025-07-07 12:59 ` Michael Dege
2025-07-04 8:33 ` [PATCH 0/3] net: renesas: rswitch: R-Car S4 add HW offloading for layer 2 switching Andrew Lunn
2025-07-07 10:41 ` Michael Dege
2025-07-07 11:53 ` Andrew Lunn
2025-07-07 12:25 ` Michael Dege
2025-07-04 8:46 ` Andrew Lunn
2025-07-04 9:05 ` Nikita Yushchenko
2025-07-04 17:53 ` Andrew Lunn [this message]
2025-07-04 17:56 ` Nikita Yushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27047e61-8307-472d-96dd-1e5b89dc427f@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=michael.dege@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=paul@pbarker.dev \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®