mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Michael Dege <michael.dege@renesas.com>
Cc: "Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
	"Paul Barker" <paul@pbarker.dev>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Nikita Yushchenko" <nikita.yoush@cogentembedded.com>
Subject: Re: [PATCH 0/3] net: renesas: rswitch: R-Car S4 add HW offloading for layer 2 switching
Date: Mon, 7 Jul 2025 13:53:32 +0200	[thread overview]
Message-ID: <dd75a12d-17cd-45a7-97d0-a243df54c215@lunn.ch> (raw)
In-Reply-To: <TY4PR01MB14282E8A9E82714106D448EA0824FA@TY4PR01MB14282.jpnprd01.prod.outlook.com>

> There is a discrepancy between the value being passed by iproute2 and brctl. Iproute2 passes the
> value unaltered in seconds and brctl passes the value in seconds multiplied by 100. So far this
> is OK because brctl is deprecated. But the default value being passed when neither brctl is called
> nor the ageing parameter is added when the bridge is created is also multiplied by 100 resulting in
> 30000s being set as default ageing time instead of 300s. Is this a known issue?

You need to be careful of 100. It is probably the value of HZ you are
using. This means it is probably in jiffies.

It could be whoever added support to DSA was using HZ = 1000, and so
assumed it has milliseconds, not jiffies, and the API is broken.

If you have time, could you dig into this. Trace there where jiffies
are used, seconds, and what conversions are preformed, for the default
values, netlink API and sysfs API. Once we know where it goes wrong,
we can figure out how to fix it.

	Andrew

  reply	other threads:[~2025-07-07 11:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-04  5:51 Michael Dege
2025-07-04  5:51 ` [PATCH 1/3] net: renesas: rswitch: rename rswitch.c to rswitch_main.c Michael Dege
2025-07-04  8:34   ` Andrew Lunn
2025-07-04  9:11   ` Niklas Söderlund
2025-07-04  5:51 ` [PATCH 2/3] net: renesas: rswitch: add offloading for L2 switching Michael Dege
2025-07-04  8:43   ` Andrew Lunn
2025-07-04  9:02     ` Nikita Yushchenko
2025-07-04 17:49       ` Andrew Lunn
2025-07-07  8:13     ` Michael Dege
2025-07-07  8:42       ` Michael Dege
2025-07-07 11:30       ` Andrew Lunn
2025-07-04  5:51 ` [PATCH 3/3] net: renesas: rswitch: add modifiable ageing time Michael Dege
2025-07-07 12:50   ` Geert Uytterhoeven
2025-07-07 12:59     ` Michael Dege
2025-07-04  8:33 ` [PATCH 0/3] net: renesas: rswitch: R-Car S4 add HW offloading for layer 2 switching Andrew Lunn
2025-07-07 10:41   ` Michael Dege
2025-07-07 11:53     ` Andrew Lunn [this message]
2025-07-07 12:25       ` Michael Dege
2025-07-04  8:46 ` Andrew Lunn
2025-07-04  9:05   ` Nikita Yushchenko
2025-07-04 17:53     ` Andrew Lunn
2025-07-04 17:56       ` Nikita Yushchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd75a12d-17cd-45a7-97d0-a243df54c215@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=michael.dege@renesas.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikita.yoush@cogentembedded.com \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=pabeni@redhat.com \
    --cc=paul@pbarker.dev \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®