From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Kayra Cizmeci <kayracizmeci@gmail.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: <albin_yang@163.com>, <albinwyang@tencent.com>,
<bsegall@google.com>, <chen.yu@linux.dev>,
<dietmar.eggemann@arm.com>, <juri.lelli@redhat.com>,
<linux-kernel@vger.kernel.org>, <mgorman@suse.de>,
<mingo@redhat.com>, <rostedt@goodmis.org>,
<vincent.guittot@linaro.org>, <vschneid@redhat.com>
Subject: Re: [PATCH] sched/stats: Fix run_delay over-count for proxy-migrated blocked donors
Date: Wed, 28 Oct 2026 09:10:00 +0530 [thread overview]
Message-ID: <0d9bce4b-0d50-46df-b865-76511b2670f6@amd.com> (raw)
In-Reply-To: <auCU65gKjdeUOoLl@scheduler.schedules>
On 10/27/2026 5:43 PM, Kayra Cizmeci wrote:
>>> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
>>> index 04b62c16fa8c..d5758b78b741 100644
>>> --- a/kernel/sched/core.c
>>> +++ b/kernel/sched/core.c
>>> @@ -3956,6 +3956,8 @@ static int ttwu_runnable(struct task_struct *p, int wake_flags)
>>> * it should preempt the task that is current now.
>>> */
>>> wakeup_preempt(rq, p, wake_flags | WF_TTWU_RQ);
>>> + /* Start accounting wait time. */
>>> + sched_info_enqueue(rq, p);
>>> }
>>> ttwu_do_wakeup(p);
>>> return 1;
>>
>> So the normal wakeup path goes through enqueue_task() which gets the
>> sched_info_enqueue() callback there. But yes, ttwu_runnable() does not
>> go through that, and needs this additional call.
>>
>> There is one more site in ttwu() that also doesn't go through
>> enqueue_task() and that is the p==current thing at the top.
>
> The counter already measures how much time a task waits for CPU,
> curr is already is at the CPU so we don't need a call from there.
>
> Or not?
Yup! on_cpu / task_current() gets dealt at sched_info_switch()
which will enqueue the signal if the task is preempted.
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2026-10-28 3:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 13:07 albin_yang
2026-10-25 19:28 ` Kayra Cizmeci
2026-10-26 13:53 ` albin_yang
2026-10-26 14:48 ` Kayra Cizmeci
2026-10-26 5:46 ` K Prateek Nayak
2026-10-26 13:38 ` albin_yang
2026-10-27 4:11 ` K Prateek Nayak
2026-10-27 6:11 ` Kayra Cizmeci
2026-10-27 6:24 ` K Prateek Nayak
2026-10-27 6:52 ` Kayra Cizmeci
2026-10-27 9:45 ` K Prateek Nayak
2026-10-27 9:53 ` Kayra Cizmeci
2026-10-27 9:58 ` K Prateek Nayak
2026-10-27 12:09 ` Peter Zijlstra
2026-10-27 12:13 ` Kayra Cizmeci
2026-10-28 3:40 ` K Prateek Nayak [this message]
2026-10-28 9:22 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d9bce4b-0d50-46df-b865-76511b2670f6@amd.com \
--to=kprateek.nayak@amd.com \
--cc=albin_yang@163.com \
--cc=albinwyang@tencent.com \
--cc=bsegall@google.com \
--cc=chen.yu@linux.dev \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kayracizmeci@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®