From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julia Lawall <julia.lawall@lip6.fr>,
Amitoj Kaur Chawla <amitoj1606@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Coccinelle <cocci@systeme.lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Michal Marek <mmarek@suse.com>,
Nicolas Palix <nicolas.palix@imag.fr>
Subject: Re: [Cocci] [PATCH v3] Coccinelle: Script to replace allocate and memset with zalloc functions
Date: Mon, 1 Aug 2016 13:56:58 +0200 [thread overview]
Message-ID: <0dbd2dd6-4c68-1f7c-1500-9e5d40047813@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1608011336590.3188@hadrien>
>> 1. Would it make sense to merge such SmPL rules into one
>> so that code duplication could be reduced a bit
>> in such a script?
>
> I think it would suffer in readability.
How do you think about the following SmPL script example?
@vz_combined
depends on patch && !context && !org && !report@
type T;
T* pointer;
+statement S;
expression express;
@@
pointer =
- vmalloc
+ vzalloc
(...);
if (!d)
S
-memset(d, 0, sizeof(
(
-T
|
-*(express)
)
-));
> Perhaps in performance as well.
I admit that I am unsure about the run-time characteristics
for my suggestion.
Regards,
Markus
next prev parent reply other threads:[~2016-08-01 11:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 7:02 Amitoj Kaur Chawla
2016-08-01 11:23 ` [Cocci] " SF Markus Elfring
2016-08-01 11:37 ` Julia Lawall
2016-08-01 11:56 ` SF Markus Elfring [this message]
2016-08-01 12:03 ` Julia Lawall
2016-08-01 12:24 ` SF Markus Elfring
2016-08-01 12:32 ` Julia Lawall
2016-08-01 12:45 ` SF Markus Elfring
2016-08-19 12:14 ` Amitoj Kaur Chawla
2016-08-19 12:41 ` Julia Lawall
2016-08-19 13:26 ` [Cocci] " SF Markus Elfring
2016-08-19 13:30 ` Julia Lawall
2016-08-19 16:56 ` SF Markus Elfring
2017-03-03 10:34 ` [Cocci] [PATCH v3] " SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dbd2dd6-4c68-1f7c-1500-9e5d40047813@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=Gilles.Muller@lip6.fr \
--cc=amitoj1606@gmail.com \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome