mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Pavel Machek <pavel@ucw.cz>
Cc: Alan Cox <alan@redhat.com>,
	Linus Torvalds <torvalds@transmeta.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Kill obsolete and  unused suspend/resume code from IDE
Date: 13 Nov 2002 14:32:22 +0000	[thread overview]
Message-ID: <1037197942.11996.67.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <20021113134208.GD10168@atrey.karlin.mff.cuni.cz>

On Wed, 2002-11-13 at 13:42, Pavel Machek wrote:
> > The code is not obsolete, it is not unused.
> 
> Can you point out what uses it? I certainly could not find it and
> killing standby/etc produced no compilation errors.
>
You were right - actually the code that uses it isnt committed into the
tree. Its also not going to be now you are doing sysfs

> As of obsolete... It is doing power managment outside of sysfs
> framework... Which is not how it should be done.
> 
> > > +	do_idedisk_standby(drive);
> > >  	if ((drive->id->cfs_enable_2 & 0x3000) && drive->wcache)
> > >  		if (do_idedisk_flushcache(drive))
> > >  			printk (KERN_INFO "%s: Write Cache FAILED Flushing!\n",
> > 
> > What locking rules are you using here ?

flushcache takes the ide lock which is already held at that point. The
code splits the unregister/standby path in two so that the unregister
doesnt deadlock

> Linus actually asked me for the patch, and discussion about it was
> public, then he silently droped it. This was "only" retransmit.

Ok.

I think your flushcache thing is safe in the new code, and I'm more than
happy for the PM changes against the new code to use sysfs to go into
the tree. 2.5.47-ac2 has pretty current ide - there isnt anything going
to get moved around dramatically again just yet (I wamt to move the
disk, tape, floppy,... drivers into a subdir later but not yet)

Alan


  reply	other threads:[~2002-11-13 14:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-12 17:51 Pavel Machek
2002-11-12 18:01 ` Alan Cox
2002-11-13 13:42   ` Pavel Machek
2002-11-13 14:32     ` Alan Cox [this message]
2002-11-13 14:17       ` Pavel Machek
     [not found] ` <1037126927.9383.5.camel@irongate.swansea.linux.org.uk>
2002-11-13 13:46   ` Pavel Machek
2002-11-13 14:13   ` Pavel Machek
2002-11-13 14:50     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1037197942.11996.67.camel@irongate.swansea.linux.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®