mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	alan@redhat.com
Subject: Re: Kill obsolete and  unused suspend/resume code from IDE
Date: Wed, 13 Nov 2002 15:13:54 +0100	[thread overview]
Message-ID: <20021113141353.GI10168@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <1037126927.9383.5.camel@irongate.swansea.linux.org.uk>

Hi!

> With the shutdown/cleanup split so the locking works out you might
> actually be able to do what you want (although I dont think you can get
> all the locking logic right yet because some of it is still hosed in the
> ide core). Also take a glance at the SC1200 driver with regards to the
> sysfs based power management handling.

SC1200 power managment looks sane. Questions:

Don't you need to wait for current operation to complete before
calling sc1200_spindown_drive?

I noticed you are not playing any tricks with inserting requests to
queues... This is basically what I was doing, so I like it.

Is sc1200_spindown_drive really sc1200 specific? Is there some problem
with doing suspend at ide.c layer, and resume (which is controller
specific) in each driver?

...Ugh. You are doing it as pci device, not as generic device. I
believe you should use sysfs directly.

Anyway I can live with this, and its way better than whats in there
just now.
								Pavel

-- 
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.

  parent reply	other threads:[~2002-11-13 14:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-12 17:51 Pavel Machek
2002-11-12 18:01 ` Alan Cox
2002-11-13 13:42   ` Pavel Machek
2002-11-13 14:32     ` Alan Cox
2002-11-13 14:17       ` Pavel Machek
     [not found] ` <1037126927.9383.5.camel@irongate.swansea.linux.org.uk>
2002-11-13 13:46   ` Pavel Machek
2002-11-13 14:13   ` Pavel Machek [this message]
2002-11-13 14:50     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021113141353.GI10168@atrey.karlin.mff.cuni.cz \
    --to=pavel@ucw.cz \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®