From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Pavel Machek <pavel@ucw.cz>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
alan@redhat.com
Subject: Re: Kill obsolete and unused suspend/resume code from IDE
Date: 13 Nov 2002 14:50:35 +0000 [thread overview]
Message-ID: <1037199035.11996.75.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <20021113141353.GI10168@atrey.karlin.mff.cuni.cz>
On Wed, 2002-11-13 at 14:13, Pavel Machek wrote:
> I noticed you are not playing any tricks with inserting requests to
> queues... This is basically what I was doing, so I like it.
>
> Is sc1200_spindown_drive really sc1200 specific? Is there some problem
> with doing suspend at ide.c layer, and resume (which is controller
> specific) in each driver?
>
> ...Ugh. You are doing it as pci device, not as generic device. I
> believe you should use sysfs directly.
>
> Anyway I can live with this, and its way better than whats in there
> just now.
If you think doing it in sysfs is the right way, then move it to sysfs.
The drive spindown is going to end up on the end of the comamnd queue
anyway. Right now we don't have any controller specific power
management, but for some controllers there is power management that we
can do when sleeping (pci D3, turning off buffers etc)
Alan
prev parent reply other threads:[~2002-11-13 14:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-12 17:51 Pavel Machek
2002-11-12 18:01 ` Alan Cox
2002-11-13 13:42 ` Pavel Machek
2002-11-13 14:32 ` Alan Cox
2002-11-13 14:17 ` Pavel Machek
[not found] ` <1037126927.9383.5.camel@irongate.swansea.linux.org.uk>
2002-11-13 13:46 ` Pavel Machek
2002-11-13 14:13 ` Pavel Machek
2002-11-13 14:50 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1037199035.11996.75.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®