Re: Kill obsolete and unused suspend/resume code from IDE

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > This code in ide is obsolete and unused. I have followup patch to
> > integrate IDE into sysfs. Please apply,
> 
> The code is not obsolete, it is not unused.

Can you point out what uses it? I certainly could not find it and
killing standby/etc produced no compilation errors.

As of obsolete... It is doing power managment outside of sysfs
framework... Which is not how it should be done.

> > +	do_idedisk_standby(drive);
> >  	if ((drive->id->cfs_enable_2 & 0x3000) && drive->wcache)
> >  		if (do_idedisk_flushcache(drive))
> >  			printk (KERN_INFO "%s: Write Cache FAILED Flushing!\n",
> 
> What locking rules are you using here ?

I did not change the code, it works exactly as it did before (ide disk
is never ATAPI device). If it is broken then sorry (but it was broken
before).

> Linus please reject this patch. Its just getting in the way of actually
> fixing the IDE code properly.

Linus actually asked me for the patch, and discussion about it was
public, then he silently droped it. This was "only" retransmit.

								Pavel
-- 
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.