From: Richard Leitner <richard.leitner@skidata.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <fugang.duan@nxp.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<dev@g0hl1n.net>
Subject: Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option
Date: Thu, 6 Jul 2017 16:33:47 +0200 [thread overview]
Message-ID: <109f44aa-87ed-6a9c-b557-8dabb2958c8c@skidata.com> (raw)
In-Reply-To: <20170706135557.GC8810@lunn.ch>
On 07/06/2017 03:55 PM, Andrew Lunn wrote:
>> diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt
>> index 6f55bdd..1766579 100644
>> --- a/Documentation/devicetree/bindings/net/fsl-fec.txt
>> +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt
>> @@ -23,6 +23,9 @@ Optional properties:
>> - phy-handle : phandle to the PHY device connected to this device.
>> - fixed-link : Assume a fixed link. See fixed-link.txt in the same directory.
>> Use instead of phy-handle.
>> +- phy-reset-after-clk-enable : If present then a phy reset and configuration
>> + will be performed everytime after the clocks are enabled. This is required
>> + for some PHYs to work properly.
>
> It sounds like this issue will apply to any LAN8710 which has its
> clock fiddled with. So this should be a centrally documented property,
> which any MAC driver can implement. Please move the above text to
> ethernet.txt, and instead have:
>
> - phy-reset-after-clk-enable : See ethernet.txt
I haven't tested it on any other platform than an i.MX6, but IMHO you're
right. It sounds reasonable that it affects any SoC which is messing
around with the clock and not performing a reset by default.
Thanks for that hint!
I'll include that in the v2.
> Thanks
> Andrew
>
regards,
Richard.L
next prev parent reply other threads:[~2017-07-06 14:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 13:05 [PATCH 1/2] net: ethernet: freescale: simplify fec_reset_phy Richard Leitner
2017-07-06 13:05 ` [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option Richard Leitner
2017-07-06 13:55 ` Andrew Lunn
2017-07-06 14:33 ` Richard Leitner [this message]
2017-07-07 5:30 ` Andy Duan
2017-07-07 5:50 ` Richard Leitner
2017-07-07 7:03 ` Andy Duan
2017-07-07 9:52 ` Richard Leitner
2017-07-07 11:08 ` Andy Duan
2017-07-07 11:16 ` Richard Leitner
2017-07-07 14:00 ` Andrew Lunn
2017-07-12 9:21 ` Richard Leitner
2017-07-12 13:40 ` Andrew Lunn
2017-07-10 13:26 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=109f44aa-87ed-6a9c-b557-8dabb2958c8c@skidata.com \
--to=richard.leitner@skidata.com \
--cc=andrew@lunn.ch \
--cc=dev@g0hl1n.net \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®