From: Richard Leitner <richard.leitner@skidata.com>
To: Andy Duan <fugang.duan@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dev@g0hl1n.net" <dev@g0hl1n.net>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option
Date: Fri, 7 Jul 2017 13:16:54 +0200 [thread overview]
Message-ID: <b68f444e-cea4-acaa-d1e9-7955a577ed35@skidata.com> (raw)
In-Reply-To: <AM4PR0401MB22609FFACD2BB51247709936FFAA0@AM4PR0401MB2260.eurprd04.prod.outlook.com>
Hi Andy,
thanks for the clarifications!
On 07/07/2017 01:08 PM, Andy Duan wrote:
>> 3. Who should then trigger the "hard reset" of the PHY? phy_init_hw? The FEC?
>>
>> The point is that the LAN8710 is currently not always working correctly,
>> therefore this small change was proposed. Should we really change all
>> PHY/FECs only because of this?
>> Furthermore one problem still remains: The enet_refclk is controlled by the
>> FEC. How does the PHY recognize when it was disabled/enabled?
>>
> Your patch is workaround for the issue. As you pointed out these is a common issue.
> So we hope to get a better solution to handle these in common code.
Ok. I'm fine with moving the phy-reset-gpios binding into the PHY. But
one question still remains: Who should then trigger the "hard reset" of
the PHY?
The PHY itself doesn't "know" when the refclk is turned off/on. So the
FEC still must call some function of the PHY after the clock was enabled
again. So the phy-reset-after-clk-enable property will remain in the fec
node? Or am I missing something?
next prev parent reply other threads:[~2017-07-07 11:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 13:05 [PATCH 1/2] net: ethernet: freescale: simplify fec_reset_phy Richard Leitner
2017-07-06 13:05 ` [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option Richard Leitner
2017-07-06 13:55 ` Andrew Lunn
2017-07-06 14:33 ` Richard Leitner
2017-07-07 5:30 ` Andy Duan
2017-07-07 5:50 ` Richard Leitner
2017-07-07 7:03 ` Andy Duan
2017-07-07 9:52 ` Richard Leitner
2017-07-07 11:08 ` Andy Duan
2017-07-07 11:16 ` Richard Leitner [this message]
2017-07-07 14:00 ` Andrew Lunn
2017-07-12 9:21 ` Richard Leitner
2017-07-12 13:40 ` Andrew Lunn
2017-07-10 13:26 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b68f444e-cea4-acaa-d1e9-7955a577ed35@skidata.com \
--to=richard.leitner@skidata.com \
--cc=andrew@lunn.ch \
--cc=dev@g0hl1n.net \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®