From: Anton Altaparmakov <aia21@cam.ac.uk>
To: Panagiotis Issaris <panagiotis.issaris@mech.kuleuven.ac.be>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] raw1394 missing failure handling
Date: Wed, 02 Mar 2005 11:33:52 +0000 [thread overview]
Message-ID: <1109763232.12379.6.camel@imp.csi.cam.ac.uk> (raw)
In-Reply-To: <42259F3A.8000206@mech.kuleuven.ac.be>
Hi,
On Wed, 2005-03-02 at 12:10 +0100, Panagiotis Issaris wrote:
> In the raw1394 driver the failure handling for
> a __copy_to_user call is missing.
Your patch is obviously incorrect as it doesn't free the request before
it returns.
Best regards,
Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
next prev parent reply other threads:[~2005-03-02 11:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 11:10 Panagiotis Issaris
2005-03-02 11:33 ` Anton Altaparmakov [this message]
2005-03-02 12:28 ` Panagiotis Issaris
2005-03-02 14:24 ` Dmitry Torokhov
2005-03-02 14:30 ` Panagiotis Issaris
2005-03-03 21:48 ` Jody McIntyre
2005-03-03 22:41 ` Panagiotis Issaris
2005-03-03 22:55 ` Panagiotis Issaris
2005-03-05 18:47 ` Jody McIntyre
2005-03-05 21:10 ` Gene Heskett
2005-03-02 11:37 ` Sergey Vlasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1109763232.12379.6.camel@imp.csi.cam.ac.uk \
--to=aia21@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=panagiotis.issaris@mech.kuleuven.ac.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®