Re: [PATCH] raw1394 missing failure handling

[Jody McIntyre <scjody@modernduck.com>]

> Thanks. Here's my third try :-)
> 
> With friendly regards,
> Takis

I'll apply this to the 1394 tree and send it to Linus after testing if
you add a Signed-off-by: line per Documentation/SubmittingPatches .
Also, please cc linux1394-devel@lists.sourceforge.net with ieee1394
changes.

Thanks,
Jody

> 
> -- 
>  K.U.Leuven, Mechanical Eng.,  Mechatronics & Robotics Research Group
>  http://people.mech.kuleuven.ac.be/~pissaris/
> 

> diff -pruN linux-2.6.11/drivers/ieee1394/raw1394.c linux-2.6.11-pi/drivers/ieee1394/raw1394.c
> --- linux-2.6.11/drivers/ieee1394/raw1394.c	2005-03-02 11:44:26.000000000 +0100
> +++ linux-2.6.11-pi/drivers/ieee1394/raw1394.c	2005-03-02 15:27:15.000000000 +0100
> @@ -443,7 +443,10 @@ static ssize_t raw1394_read(struct file 
>                          req->req.error = RAW1394_ERROR_MEMFAULT;
>                  }
>          }
> -        __copy_to_user(buffer, &req->req, sizeof(req->req));
> +        if (__copy_to_user(buffer, &req->req, sizeof(req->req))) {
> +                free_pending_request(req);
> +                return -EFAULT;
> +        }
>  
>          free_pending_request(req);
>          return sizeof(struct raw1394_request);


--