mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Panagiotis Issaris <panagiotis.issaris@mech.kuleuven.ac.be>
Cc: Anton Altaparmakov <aia21@cam.ac.uk>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] raw1394 missing failure handling
Date: Wed, 2 Mar 2005 09:24:37 -0500	[thread overview]
Message-ID: <d120d500050302062451cc2af3@mail.gmail.com> (raw)
In-Reply-To: <4225B167.3030903@mech.kuleuven.ac.be>

On Wed, 02 Mar 2005 13:28:23 +0100, Panagiotis Issaris
<panagiotis.issaris@mech.kuleuven.ac.be> wrote:
> Hi,
> 
> Anton Altaparmakov wrote:
> 
> >On Wed, 2005-03-02 at 12:10 +0100, Panagiotis Issaris wrote:
> >
> >
> >>In the raw1394 driver the failure handling for
> >>a __copy_to_user call is missing.
> >>
> >>
> >
> >Your patch is obviously incorrect as it doesn't free the request before
> >it returns.
> >
> >
> Oops. Thanks for replying! Any more problems with the updated
> patch?
> 

Formatting... Opening curly brace should go on the same line with "if".

-- 
Dmitry

  reply	other threads:[~2005-03-02 14:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-02 11:10 Panagiotis Issaris
2005-03-02 11:33 ` Anton Altaparmakov
2005-03-02 12:28   ` Panagiotis Issaris
2005-03-02 14:24     ` Dmitry Torokhov [this message]
2005-03-02 14:30       ` Panagiotis Issaris
2005-03-03 21:48         ` Jody McIntyre
2005-03-03 22:41           ` Panagiotis Issaris
2005-03-03 22:55           ` Panagiotis Issaris
2005-03-05 18:47             ` Jody McIntyre
2005-03-05 21:10               ` Gene Heskett
2005-03-02 11:37 ` Sergey Vlasov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d120d500050302062451cc2af3@mail.gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=aia21@cam.ac.uk \
    --cc=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=panagiotis.issaris@mech.kuleuven.ac.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome