From: Panagiotis Issaris <panagiotis.issaris@mech.kuleuven.ac.be>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] raw1394 missing failure handling
Date: Wed, 02 Mar 2005 12:10:50 +0100 [thread overview]
Message-ID: <42259F3A.8000206@mech.kuleuven.ac.be> (raw)
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
Hi,
In the raw1394 driver the failure handling for
a __copy_to_user call is missing.
With friendly regards,
Takis
--
K.U.Leuven, Mechanical Eng., Mechatronics & Robotics Research Group
http://people.mech.kuleuven.ac.be/~pissaris/
[-- Attachment #2: pi-20050302T114855-linux_2_6_11-raw1394_copy_to_user_failure_handling.diff --]
[-- Type: text/x-patch, Size: 661 bytes --]
diff -pruN linux-2.6.11/drivers/ieee1394/raw1394.c linux-2.6.11-pi/drivers/ieee1394/raw1394.c
--- linux-2.6.11/drivers/ieee1394/raw1394.c 2005-03-02 11:44:26.000000000 +0100
+++ linux-2.6.11-pi/drivers/ieee1394/raw1394.c 2005-03-02 11:47:38.000000000 +0100
@@ -443,7 +443,8 @@ static ssize_t raw1394_read(struct file
req->req.error = RAW1394_ERROR_MEMFAULT;
}
}
- __copy_to_user(buffer, &req->req, sizeof(req->req));
+ if (__copy_to_user(buffer, &req->req, sizeof(req->req)))
+ return -EFAULT;
free_pending_request(req);
return sizeof(struct raw1394_request);
next reply other threads:[~2005-03-02 11:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 11:10 Panagiotis Issaris [this message]
2005-03-02 11:33 ` Anton Altaparmakov
2005-03-02 12:28 ` Panagiotis Issaris
2005-03-02 14:24 ` Dmitry Torokhov
2005-03-02 14:30 ` Panagiotis Issaris
2005-03-03 21:48 ` Jody McIntyre
2005-03-03 22:41 ` Panagiotis Issaris
2005-03-03 22:55 ` Panagiotis Issaris
2005-03-05 18:47 ` Jody McIntyre
2005-03-05 21:10 ` Gene Heskett
2005-03-02 11:37 ` Sergey Vlasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42259F3A.8000206@mech.kuleuven.ac.be \
--to=panagiotis.issaris@mech.kuleuven.ac.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®