From: Arjan van de Ven <arjan@infradead.org>
To: Eduardo Pereira Habkost <ehabkost@mandriva.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Oliver Neukum <oliver@neukum.org>,
linux-usb-devel@lists.sourceforge.net, Greg KH <gregkh@suse.de>,
Luiz Fernando Capitulino <lcapitulino@mandriva.com.br>,
linux-kernel@vger.kernel.org
Subject: Re: [linux-usb-devel] Re: [PATCH 00/10] usb-serial: Switches from spin lock to atomic_t.
Date: Wed, 07 Dec 2005 17:02:33 +0100 [thread overview]
Message-ID: <1133971353.2869.41.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20051207160047.GG20451@duckman.conectiva>
> > No they're not. Both are just about equally expensive cpu wise,
> > sometimes the atomic_t ones are a bit more expensive (like on parisc
> > architecture). But on x86 in either case it's a locked cycle, which is
> > just expensive no matter which side you flip the coin...
>
> But if a lock is used exclusively to protect a int variable, an atomic_t
> seems to be more appropriate to me. Isn't it?
sounds like it...
> Please, if you could, review the patches with this in mind: we aren't
> changing any behaviour neither creating any weird lock scheme, we are
> only doing two things:
... however you are NOT changing the behavior, which is EXACTLY my
point; the current "lock emulation" behavior is wrong, all you're doing
is replacing how you do the wrong thing ;)
It's like having a bike with square wheels, and replacing a flat tire
with one with air in, as opposed to replacing it with a round wheel...
next prev parent reply other threads:[~2005-12-07 16:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-06 11:56 Luiz Fernando Capitulino
2005-12-06 19:40 ` Greg KH
2005-12-06 20:13 ` Eduardo Pereira Habkost
2005-12-06 22:48 ` [linux-usb-devel] " Oliver Neukum
2005-12-07 12:24 ` Luiz Fernando Capitulino
2005-12-07 12:27 ` Arjan van de Ven
2005-12-07 12:30 ` Luiz Fernando Capitulino
2005-12-07 12:34 ` Arjan van de Ven
2005-12-07 12:41 ` Luiz Fernando Capitulino
2005-12-07 12:54 ` Luiz Fernando Capitulino
2005-12-07 15:07 ` Alan Stern
2005-12-07 15:22 ` Arjan van de Ven
2005-12-07 15:37 ` Oliver Neukum
2005-12-07 15:40 ` Arjan van de Ven
2005-12-07 15:50 ` Oliver Neukum
2005-12-07 16:02 ` Alan Cox
2005-12-07 16:00 ` Eduardo Pereira Habkost
2005-12-07 16:02 ` Arjan van de Ven [this message]
2005-12-07 16:23 ` Eduardo Pereira Habkost
2005-12-07 16:01 ` Alan Stern
2005-12-07 16:04 ` Arjan van de Ven
2005-12-07 15:32 ` linux-os (Dick Johnson)
2005-12-07 16:08 ` Alan Stern
2005-12-06 20:14 ` Luiz Fernando Capitulino
2005-12-06 21:02 ` Pete Zaitcev
2005-12-06 21:18 ` Luiz Fernando Capitulino
2005-12-06 22:36 ` [linux-usb-devel] " Oliver Neukum
2005-12-07 12:25 ` Luiz Fernando Capitulino
2005-12-07 13:01 ` Oliver Neukum
2005-12-07 13:17 ` Luiz Fernando Capitulino
2005-12-07 16:41 ` Greg KH
2005-12-07 16:51 ` Luiz Fernando Capitulino
2005-12-07 17:13 ` Eduardo Pereira Habkost
2005-12-07 17:56 ` Greg KH
2005-12-07 19:10 ` Eduardo Pereira Habkost
2005-12-07 16:55 ` Otavio Salvador
2005-12-07 16:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133971353.2869.41.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=ehabkost@mandriva.com \
--cc=gregkh@suse.de \
--cc=lcapitulino@mandriva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=oliver@neukum.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®