From: Paul Fulghum <paulkf@microgate.com>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Dave Jones <davej@redhat.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org,
zippel@linux-m68k.org
Subject: [PATCH] fix missing hdlc symbols for synclink drivers
Date: Tue, 06 Jun 2006 14:40:13 -0500 [thread overview]
Message-ID: <1149622813.11929.3.camel@amdx2.microgate.com> (raw)
In-Reply-To: <20060605184407.230bcf73.rdunlap@xenotime.net>
Randy:
This patch of yours is the only way I've found to
fix the random config build errors and maintain
the necessary flexibility of configuration for the
synclink drivers. I added the synclink_cs config to
the end of your patch.
--
From: Randy Dunlap <rdunlap@xenotime.net>
Fix many missing hdlc_generic symbols when CONFIG_HDLC=m.
When Selecting HDLC, also Select WAN.
Fix Makefile to build for HDLC=y or HDLC=m.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Paul Fulghum <paulkf@microgate.com>
--- linux-2.6.17-rc5-mm3/drivers/net/wan/Makefile 2006-06-06 14:03:59.000000000 -0500
+++ b/drivers/net/wan/Makefile 2006-06-06 14:08:53.000000000 -0500
@@ -9,14 +9,18 @@ cyclomx-y := cycx_
cyclomx-$(CONFIG_CYCLOMX_X25) += cycx_x25.o
cyclomx-objs := $(cyclomx-y)
-hdlc-y := hdlc_generic.o
+hdlc-$(CONFIG_HDLC) := hdlc_generic.o
hdlc-$(CONFIG_HDLC_RAW) += hdlc_raw.o
hdlc-$(CONFIG_HDLC_RAW_ETH) += hdlc_raw_eth.o
hdlc-$(CONFIG_HDLC_CISCO) += hdlc_cisco.o
hdlc-$(CONFIG_HDLC_FR) += hdlc_fr.o
hdlc-$(CONFIG_HDLC_PPP) += hdlc_ppp.o
hdlc-$(CONFIG_HDLC_X25) += hdlc_x25.o
-hdlc-objs := $(hdlc-y)
+ifeq ($(CONFIG_HDLC),y)
+ hdlc-objs := $(hdlc-y)
+else
+ hdlc-objs := $(hdlc-m)
+endif
pc300-y := pc300_drv.o
pc300-$(CONFIG_PC300_MLPPP) += pc300_tty.o
--- linux-2.6.17-rc5-mm3/drivers/char/Kconfig 2006-06-06 14:03:58.000000000 -0500
+++ b/drivers/char/Kconfig 2006-06-06 14:08:53.000000000 -0500
@@ -197,6 +197,7 @@ config ISI
config SYNCLINK
tristate "SyncLink PCI/ISA support"
depends on SERIAL_NONSTANDARD && PCI && ISA_DMA_API
+ select WAN if SYNCLINK_HDLC
select HDLC if SYNCLINK_HDLC
help
Driver for SyncLink ISA and PCI synchronous serial adapters.
@@ -214,6 +215,7 @@ config SYNCLINK_HDLC
config SYNCLINKMP
tristate "SyncLink Multiport support"
depends on SERIAL_NONSTANDARD && PCI
+ select WAN if SYNCLINKMP_HDLC
select HDLC if SYNCLINKMP_HDLC
help
Driver for SyncLink Multiport (2 or 4 ports) PCI synchronous serial adapter.
@@ -231,6 +233,7 @@ config SYNCLINKMP_HDLC
config SYNCLINK_GT
tristate "SyncLink GT/AC support"
depends on SERIAL_NONSTANDARD && PCI
+ select WAN if SYNCLINK_GT_HDLC
select HDLC if SYNCLINK_GT_HDLC
help
Support for SyncLink GT and SyncLink AC families of
--- linux-2.6.17-rc5-mm3/drivers/char/pcmcia/Kconfig 2006-06-06 14:03:58.000000000 -0500
+++ b/drivers/char/pcmcia/Kconfig 2006-06-06 14:09:25.000000000 -0500
@@ -8,6 +8,7 @@ menu "PCMCIA character devices"
config SYNCLINK_CS
tristate "SyncLink PC Card support"
depends on PCMCIA
+ select WAN if SYNCLINK_CS_HDLC
select HDLC if SYNCLINK_CS_HDLC
help
Driver for SyncLink PC Card synchronous serial adapter.
next prev parent reply other threads:[~2006-06-06 19:40 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-04 6:20 2.6.17-rc5-mm3 Andrew Morton
2006-06-04 9:38 ` 2.6.17-rc5-mm3 Barry K. Nathan
2006-06-04 9:49 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-04 10:08 ` 2.6.17-rc5-mm3 Michal Piotrowski
2006-06-04 10:41 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-04 20:38 ` 2.6.17-rc5-mm3 Valdis.Kletnieks
2006-06-04 21:49 ` [patch, -rc5-mm3] lock validator: early_init_irq_lock_type() build fix Ingo Molnar
[not found] ` <6bffcb0e0606040407u4f56f7fdyf5ec479314afc082@mail.gmail.com>
2006-06-04 21:38 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-04 22:35 ` 2.6.17-rc5-mm3 Michal Piotrowski
2006-06-05 8:30 ` [patch, -rc5-mm3] fix IDE deadlock in error reporting code Ingo Molnar
2006-06-05 8:35 ` Ingo Molnar
2006-06-05 11:33 ` Michal Piotrowski
2006-06-05 12:24 ` Ingo Molnar
2006-06-05 12:35 ` Michal Piotrowski
2006-06-04 18:20 ` 2.6.17-rc5-mm3 Rafael J. Wysocki
2006-06-04 23:01 ` [trivial patch, rc5-mm3] fix typo in acpi pm info message Frederik Deweerdt
2006-06-04 23:15 ` 2.6.17-rc5-mm3 J.A. Magallón
2006-06-04 23:42 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-05 6:02 ` 2.6.17-rc5-mm3 Valdis.Kletnieks
2006-06-05 8:04 ` 2.6.17-rc5-mm3 Arjan van de Ven
2006-06-04 23:28 ` 2.6.17-rc5-mm3 J.A. Magallón
2006-06-05 0:06 ` 2.6.17-rc5-mm3 Barry K. Nathan
2006-06-05 0:25 ` 2.6.17-rc5-mm3 Grant Coady
2006-06-05 0:45 ` 2.6.17-rc5-mm3 Grant Coady
2006-06-05 9:12 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-05 17:56 ` 2.6.17-rc5-mm3 Mel Gorman
2006-06-05 18:54 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-06 9:43 ` 2.6.17-rc5-mm3 Mel Gorman
2006-06-06 10:57 ` 2.6.17-rc5-mm3 Mel Gorman
2006-06-05 19:48 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 20:06 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-05 20:09 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 20:44 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 20:53 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-05 21:02 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 21:03 ` 2.6.17-rc5-mm3 Arjan van de Ven
2006-06-06 10:15 ` 2.6.17-rc5-mm3 Takashi Iwai
2006-06-05 23:02 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-06 1:44 ` 2.6.17-rc5-mm3 Randy.Dunlap
2006-06-06 1:54 ` 2.6.17-rc5-mm3 Paul Fulghum
2006-06-06 2:03 ` 2.6.17-rc5-mm3 Randy.Dunlap
2006-06-06 2:19 ` 2.6.17-rc5-mm3 Randy.Dunlap
2006-06-06 2:35 ` 2.6.17-rc5-mm3 Paul Fulghum
2006-06-06 13:30 ` 2.6.17-rc5-mm3 Paul Fulghum
2006-06-06 19:40 ` Paul Fulghum [this message]
2006-06-06 20:27 ` [PATCH] fix missing hdlc symbols for synclink drivers Krzysztof Halasa
2006-06-06 20:35 ` Paul Fulghum
2006-06-06 21:09 ` Krzysztof Halasa
2006-06-06 21:20 ` Randy.Dunlap
2006-06-06 21:31 ` Krzysztof Halasa
2006-06-06 21:43 ` Paul Fulghum
2006-06-06 20:45 ` Randy.Dunlap
2006-06-06 20:48 ` Randy.Dunlap
2006-06-06 21:08 ` Randy.Dunlap
2006-06-06 22:44 ` Krzysztof Halasa
2006-06-06 22:52 ` Paul Fulghum
2006-06-06 23:07 ` Randy.Dunlap
2006-06-06 23:22 ` Paul Fulghum
2006-06-06 23:37 ` Krzysztof Halasa
2006-06-06 23:51 ` Randy.Dunlap
2006-06-06 23:56 ` Paul Fulghum
2006-06-07 0:12 ` Randy.Dunlap
2006-06-07 0:31 ` Paul Fulghum
2006-06-07 1:20 ` Remove patch from 2.6.17-rc5-mm3 Paul Fulghum
2006-06-07 0:42 ` [PATCH] fix missing hdlc symbols for synclink drivers Krzysztof Halasa
2006-06-07 1:09 ` Paul Fulghum
2006-06-06 23:11 ` Randy.Dunlap
2006-06-06 21:11 ` Krzysztof Halasa
2006-06-06 21:25 ` Randy.Dunlap
2006-06-06 8:03 ` 2.6.17-rc5-mm3 J.A. Magallón
2006-06-06 8:09 ` [patch, -rc5-mm3] lock validator: add local_irq_enable_in_hardirq() to ide-floppy.c Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149622813.11929.3.camel@amdx2.microgate.com \
--to=paulkf@microgate.com \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome