From: "Michal Piotrowski" <michal.k.k.piotrowski@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Andrew Morton" <akpm@osdl.org>,
"Arjan van de Ven" <arjan@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch, -rc5-mm3] fix IDE deadlock in error reporting code
Date: Mon, 5 Jun 2006 13:33:25 +0200 [thread overview]
Message-ID: <6bffcb0e0606050433i1261d3e4sd0d958fb15208596@mail.gmail.com> (raw)
In-Reply-To: <20060605083530.GA31738@elte.hu>
Hi,
On 05/06/06, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Ingo Molnar <mingo@elte.hu> wrote:
>
> > ah. That's a real deadlock scenario. Does the patch below fix it? If
> > yes then i think this is a candidate for 2.6.17 merging too.
>
> actually, the replacement patch below is better i think - it moves the
> ide_lock taking to outside the printing section. That should still be OK
> as we dont call other functions from within the section, and it should
> also result in slightly more robust printing, as the whole printing code
> will be atomic under ide_lock.
Probably fixed, thanks.
>
> Ingo
>
Regards,
Michal
--
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)
next prev parent reply other threads:[~2006-06-05 11:33 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-04 6:20 2.6.17-rc5-mm3 Andrew Morton
2006-06-04 9:38 ` 2.6.17-rc5-mm3 Barry K. Nathan
2006-06-04 9:49 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-04 10:08 ` 2.6.17-rc5-mm3 Michal Piotrowski
2006-06-04 10:41 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-04 20:38 ` 2.6.17-rc5-mm3 Valdis.Kletnieks
2006-06-04 21:49 ` [patch, -rc5-mm3] lock validator: early_init_irq_lock_type() build fix Ingo Molnar
[not found] ` <6bffcb0e0606040407u4f56f7fdyf5ec479314afc082@mail.gmail.com>
2006-06-04 21:38 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-04 22:35 ` 2.6.17-rc5-mm3 Michal Piotrowski
2006-06-05 8:30 ` [patch, -rc5-mm3] fix IDE deadlock in error reporting code Ingo Molnar
2006-06-05 8:35 ` Ingo Molnar
2006-06-05 11:33 ` Michal Piotrowski [this message]
2006-06-05 12:24 ` Ingo Molnar
2006-06-05 12:35 ` Michal Piotrowski
2006-06-04 18:20 ` 2.6.17-rc5-mm3 Rafael J. Wysocki
2006-06-04 23:01 ` [trivial patch, rc5-mm3] fix typo in acpi pm info message Frederik Deweerdt
2006-06-04 23:15 ` 2.6.17-rc5-mm3 J.A. Magallón
2006-06-04 23:42 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-05 6:02 ` 2.6.17-rc5-mm3 Valdis.Kletnieks
2006-06-05 8:04 ` 2.6.17-rc5-mm3 Arjan van de Ven
2006-06-04 23:28 ` 2.6.17-rc5-mm3 J.A. Magallón
2006-06-05 0:06 ` 2.6.17-rc5-mm3 Barry K. Nathan
2006-06-05 0:25 ` 2.6.17-rc5-mm3 Grant Coady
2006-06-05 0:45 ` 2.6.17-rc5-mm3 Grant Coady
2006-06-05 9:12 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-05 17:56 ` 2.6.17-rc5-mm3 Mel Gorman
2006-06-05 18:54 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-06 9:43 ` 2.6.17-rc5-mm3 Mel Gorman
2006-06-06 10:57 ` 2.6.17-rc5-mm3 Mel Gorman
2006-06-05 19:48 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 20:06 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-05 20:09 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 20:44 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 20:53 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-05 21:02 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 21:03 ` 2.6.17-rc5-mm3 Arjan van de Ven
2006-06-06 10:15 ` 2.6.17-rc5-mm3 Takashi Iwai
2006-06-05 23:02 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-06 1:44 ` 2.6.17-rc5-mm3 Randy.Dunlap
2006-06-06 1:54 ` 2.6.17-rc5-mm3 Paul Fulghum
2006-06-06 2:03 ` 2.6.17-rc5-mm3 Randy.Dunlap
2006-06-06 2:19 ` 2.6.17-rc5-mm3 Randy.Dunlap
2006-06-06 2:35 ` 2.6.17-rc5-mm3 Paul Fulghum
2006-06-06 13:30 ` 2.6.17-rc5-mm3 Paul Fulghum
2006-06-06 19:40 ` [PATCH] fix missing hdlc symbols for synclink drivers Paul Fulghum
2006-06-06 20:27 ` Krzysztof Halasa
2006-06-06 20:35 ` Paul Fulghum
2006-06-06 21:09 ` Krzysztof Halasa
2006-06-06 21:20 ` Randy.Dunlap
2006-06-06 21:31 ` Krzysztof Halasa
2006-06-06 21:43 ` Paul Fulghum
2006-06-06 20:45 ` Randy.Dunlap
2006-06-06 20:48 ` Randy.Dunlap
2006-06-06 21:08 ` Randy.Dunlap
2006-06-06 22:44 ` Krzysztof Halasa
2006-06-06 22:52 ` Paul Fulghum
2006-06-06 23:07 ` Randy.Dunlap
2006-06-06 23:22 ` Paul Fulghum
2006-06-06 23:37 ` Krzysztof Halasa
2006-06-06 23:51 ` Randy.Dunlap
2006-06-06 23:56 ` Paul Fulghum
2006-06-07 0:12 ` Randy.Dunlap
2006-06-07 0:31 ` Paul Fulghum
2006-06-07 1:20 ` Remove patch from 2.6.17-rc5-mm3 Paul Fulghum
2006-06-07 0:42 ` [PATCH] fix missing hdlc symbols for synclink drivers Krzysztof Halasa
2006-06-07 1:09 ` Paul Fulghum
2006-06-06 23:11 ` Randy.Dunlap
2006-06-06 21:11 ` Krzysztof Halasa
2006-06-06 21:25 ` Randy.Dunlap
2006-06-06 8:03 ` 2.6.17-rc5-mm3 J.A. Magallón
2006-06-06 8:09 ` [patch, -rc5-mm3] lock validator: add local_irq_enable_in_hardirq() to ide-floppy.c Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bffcb0e0606050433i1261d3e4sd0d958fb15208596@mail.gmail.com \
--to=michal.k.k.piotrowski@gmail.com \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®