Re: 2.6.17-rc5-mm3

[Paul Fulghum <paulkf@microgate.com>]

Randy.Dunlap wrote:
> Here's another version of the patch for you to consider.
> ---
> --- linux-2617-rc5mm3.orig/drivers/char/Kconfig
> +++ linux-2617-rc5mm3/drivers/char/Kconfig
> @@ -197,7 +197,6 @@ config ISI
>  config SYNCLINK
>  	tristate "SyncLink PCI/ISA support"
>  	depends on SERIAL_NONSTANDARD && PCI && ISA_DMA_API
> -	select HDLC if SYNCLINK_HDLC
>  	help
>  	  Driver for SyncLink ISA and PCI synchronous serial adapters.
>  	  These adapters are no longer in production and have
> @@ -205,7 +204,7 @@ config SYNCLINK
>  
>  config SYNCLINK_HDLC
>  	bool "Generic HDLC support for SyncLink driver"
> -	depends on SYNCLINK
> +	depends on SYNCLINK && HDLC
>  	help
>  	  Enable generic HDLC support for the SyncLink PCI/ISA driver.
>  	  Generic HDLC implements multiple higher layer networking

Now I remember that this was tried before and does
not work because SYNCLINK_HDLC is a bool and will
force the HDLC module to 'y' even if the synclink
driver is a 'm' which results in build errors.

I also tried 'depends on HDLC if SYNCLINK_HDLC'
in the config SYNCLINK section, but that causes a
cyclic dependency error. I suppose I could do that if I
remove 'depends on SYNCLINK' from config SYNCLINK_HDLC.
The only down side of that is the way the
SYNCLINK_HDLC option would be displayed.

I'll review this again to find the best solution.

-- 
Paul Fulghum
Microgate Systems, Ltd.