From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: paulkf@microgate.com
Cc: davej@redhat.com, akpm@osdl.org, linux-kernel@vger.kernel.org,
zippel@linux-m68k.org
Subject: Re: 2.6.17-rc5-mm3
Date: Mon, 5 Jun 2006 19:19:51 -0700 [thread overview]
Message-ID: <20060605191951.1ee122d3.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060605190355.c1be6d75.rdunlap@xenotime.net>
On Mon, 5 Jun 2006 19:03:55 -0700 Randy.Dunlap wrote:
> On Mon, 05 Jun 2006 20:54:51 -0500 Paul Fulghum wrote:
>
> > Randy.Dunlap wrote:
> > > Those Kconfig + Makefiles are quite ugly to me. I would rather see
> > > SYNCLINK depend on HDLC rather than using some tricks to SELECT HDLC.
> > > And then it selects HDLC (and HDLC depends on WAN), but (in my case)
> > > WAN was not enabled, and doing "SELECT HDLC" did not enable WAN.
> > >
> > > Adding SELECT WAN and changing the hdlc (wan) Makefile to use
> > > obj-m or obj-y (it was ONLY obj-y for hdlc) fixes^W makes it build
> > > with no missing symbols. However, I'll also see about a fix
> > > that uses "depends on HDLC" instead of "selects HDLC".
> >
> > Generic HDLC support in the synclink drivers is optional.
> > Should the generic HDLC code be enabled even if it is not used?
> >
> > Some of our customers would scream if we started forcing
> > them to compile and load unused code.
>
> OK, I'll try to allow for that.
>
> > > Fix many missing hdlc_generic symbols when CONFIG_HDLC=m.
> > > When Selecting HDLC, also Select WAN.
> > > Fix Makefile to build for HDLC=y or HDLC=m.
> > >
> > > + select WAN if SYNCLINK_HDLC
> >
> > If this is the accepted approach, then synclink_cs should be added also.
> > (drivers/char/pcmcia)
>
> It's not the desired approach AFAIK, but it may be the only
> reasonable one. I'm still testing alternatives, but you are welcome
> to take over and fix it. :)
>
> > What about select WAN if HDLC instead?
> > Or does kbuild not propogate the reverse dependency?
> > (SYNCLINK_HDLC selects HDLC, HDLC selects WAN)
>
> OK.
Hi Paul,
Here's another version of the patch for you to consider.
---
From: Randy Dunlap <rdunlap@xenotime.net>
Fix missing symbol references to hdlc_generic functions.
Switch SYNCLINK drivers from using SELECT to using DEPENDS for HDLC.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/char/Kconfig | 9 +++------
drivers/char/pcmcia/Kconfig | 3 +--
drivers/net/wan/Makefile | 8 ++++++--
3 files changed, 10 insertions(+), 10 deletions(-)
--- linux-2617-rc5mm3.orig/drivers/char/Kconfig
+++ linux-2617-rc5mm3/drivers/char/Kconfig
@@ -197,7 +197,6 @@ config ISI
config SYNCLINK
tristate "SyncLink PCI/ISA support"
depends on SERIAL_NONSTANDARD && PCI && ISA_DMA_API
- select HDLC if SYNCLINK_HDLC
help
Driver for SyncLink ISA and PCI synchronous serial adapters.
These adapters are no longer in production and have
@@ -205,7 +204,7 @@ config SYNCLINK
config SYNCLINK_HDLC
bool "Generic HDLC support for SyncLink driver"
- depends on SYNCLINK
+ depends on SYNCLINK && HDLC
help
Enable generic HDLC support for the SyncLink PCI/ISA driver.
Generic HDLC implements multiple higher layer networking
@@ -214,7 +213,6 @@ config SYNCLINK_HDLC
config SYNCLINKMP
tristate "SyncLink Multiport support"
depends on SERIAL_NONSTANDARD && PCI
- select HDLC if SYNCLINKMP_HDLC
help
Driver for SyncLink Multiport (2 or 4 ports) PCI synchronous serial adapter.
These adapters are no longer in production and have
@@ -222,7 +220,7 @@ config SYNCLINKMP
config SYNCLINKMP_HDLC
bool "Generic HDLC support for SyncLink Multiport"
- depends on SYNCLINKMP
+ depends on SYNCLINKMP && HDLC
help
Enable generic HDLC support for the SyncLink Multiport driver.
Generic HDLC implements multiple higher layer networking
@@ -231,7 +229,6 @@ config SYNCLINKMP_HDLC
config SYNCLINK_GT
tristate "SyncLink GT/AC support"
depends on SERIAL_NONSTANDARD && PCI
- select HDLC if SYNCLINK_GT_HDLC
help
Support for SyncLink GT and SyncLink AC families of
synchronous and asynchronous serial adapters
@@ -239,7 +236,7 @@ config SYNCLINK_GT
config SYNCLINK_GT_HDLC
bool "Generic HDLC support for SyncLink GT/AC"
- depends on SYNCLINK_GT
+ depends on SYNCLINK_GT && HDLC
help
Enable generic HDLC support for the SyncLink GT/AC driver.
Generic HDLC implements multiple higher layer networking
--- linux-2617-rc5mm3.orig/drivers/char/pcmcia/Kconfig
+++ linux-2617-rc5mm3/drivers/char/pcmcia/Kconfig
@@ -8,13 +8,12 @@ menu "PCMCIA character devices"
config SYNCLINK_CS
tristate "SyncLink PC Card support"
depends on PCMCIA
- select HDLC if SYNCLINK_CS_HDLC
help
Driver for SyncLink PC Card synchronous serial adapter.
config SYNCLINK_CS_HDLC
bool "Generic HDLC support for SyncLink Multiport"
- depends on SYNCLINK_CS
+ depends on SYNCLINK_CS && HDLC
help
Enable generic HDLC support for the SyncLink PC Card driver.
Generic HDLC implements multiple higher layer networking
--- linux-2617-rc5mm3.orig/drivers/net/wan/Makefile
+++ linux-2617-rc5mm3/drivers/net/wan/Makefile
@@ -9,14 +9,18 @@ cyclomx-y := cycx_
cyclomx-$(CONFIG_CYCLOMX_X25) += cycx_x25.o
cyclomx-objs := $(cyclomx-y)
-hdlc-y := hdlc_generic.o
+hdlc-$(CONFIG_HDLC) := hdlc_generic.o
hdlc-$(CONFIG_HDLC_RAW) += hdlc_raw.o
hdlc-$(CONFIG_HDLC_RAW_ETH) += hdlc_raw_eth.o
hdlc-$(CONFIG_HDLC_CISCO) += hdlc_cisco.o
hdlc-$(CONFIG_HDLC_FR) += hdlc_fr.o
hdlc-$(CONFIG_HDLC_PPP) += hdlc_ppp.o
hdlc-$(CONFIG_HDLC_X25) += hdlc_x25.o
-hdlc-objs := $(hdlc-y)
+ifeq ($(CONFIG_HDLC),y)
+ hdlc-objs := $(hdlc-y)
+else
+ hdlc-objs := $(hdlc-m)
+endif
pc300-y := pc300_drv.o
pc300-$(CONFIG_PC300_MLPPP) += pc300_tty.o
next prev parent reply other threads:[~2006-06-06 2:17 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-04 6:20 2.6.17-rc5-mm3 Andrew Morton
2006-06-04 9:38 ` 2.6.17-rc5-mm3 Barry K. Nathan
2006-06-04 9:49 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-04 10:08 ` 2.6.17-rc5-mm3 Michal Piotrowski
2006-06-04 10:41 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-04 20:38 ` 2.6.17-rc5-mm3 Valdis.Kletnieks
2006-06-04 21:49 ` [patch, -rc5-mm3] lock validator: early_init_irq_lock_type() build fix Ingo Molnar
[not found] ` <6bffcb0e0606040407u4f56f7fdyf5ec479314afc082@mail.gmail.com>
2006-06-04 21:38 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-04 22:35 ` 2.6.17-rc5-mm3 Michal Piotrowski
2006-06-05 8:30 ` [patch, -rc5-mm3] fix IDE deadlock in error reporting code Ingo Molnar
2006-06-05 8:35 ` Ingo Molnar
2006-06-05 11:33 ` Michal Piotrowski
2006-06-05 12:24 ` Ingo Molnar
2006-06-05 12:35 ` Michal Piotrowski
2006-06-04 18:20 ` 2.6.17-rc5-mm3 Rafael J. Wysocki
2006-06-04 23:01 ` [trivial patch, rc5-mm3] fix typo in acpi pm info message Frederik Deweerdt
2006-06-04 23:15 ` 2.6.17-rc5-mm3 J.A. Magallón
2006-06-04 23:42 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-05 6:02 ` 2.6.17-rc5-mm3 Valdis.Kletnieks
2006-06-05 8:04 ` 2.6.17-rc5-mm3 Arjan van de Ven
2006-06-04 23:28 ` 2.6.17-rc5-mm3 J.A. Magallón
2006-06-05 0:06 ` 2.6.17-rc5-mm3 Barry K. Nathan
2006-06-05 0:25 ` 2.6.17-rc5-mm3 Grant Coady
2006-06-05 0:45 ` 2.6.17-rc5-mm3 Grant Coady
2006-06-05 9:12 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-05 17:56 ` 2.6.17-rc5-mm3 Mel Gorman
2006-06-05 18:54 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-06 9:43 ` 2.6.17-rc5-mm3 Mel Gorman
2006-06-06 10:57 ` 2.6.17-rc5-mm3 Mel Gorman
2006-06-05 19:48 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 20:06 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-05 20:09 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 20:44 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 20:53 ` 2.6.17-rc5-mm3 Andrew Morton
2006-06-05 21:02 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 21:03 ` 2.6.17-rc5-mm3 Arjan van de Ven
2006-06-06 10:15 ` 2.6.17-rc5-mm3 Takashi Iwai
2006-06-05 23:02 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-06 1:44 ` 2.6.17-rc5-mm3 Randy.Dunlap
2006-06-06 1:54 ` 2.6.17-rc5-mm3 Paul Fulghum
2006-06-06 2:03 ` 2.6.17-rc5-mm3 Randy.Dunlap
2006-06-06 2:19 ` Randy.Dunlap [this message]
2006-06-06 2:35 ` 2.6.17-rc5-mm3 Paul Fulghum
2006-06-06 13:30 ` 2.6.17-rc5-mm3 Paul Fulghum
2006-06-06 19:40 ` [PATCH] fix missing hdlc symbols for synclink drivers Paul Fulghum
2006-06-06 20:27 ` Krzysztof Halasa
2006-06-06 20:35 ` Paul Fulghum
2006-06-06 21:09 ` Krzysztof Halasa
2006-06-06 21:20 ` Randy.Dunlap
2006-06-06 21:31 ` Krzysztof Halasa
2006-06-06 21:43 ` Paul Fulghum
2006-06-06 20:45 ` Randy.Dunlap
2006-06-06 20:48 ` Randy.Dunlap
2006-06-06 21:08 ` Randy.Dunlap
2006-06-06 22:44 ` Krzysztof Halasa
2006-06-06 22:52 ` Paul Fulghum
2006-06-06 23:07 ` Randy.Dunlap
2006-06-06 23:22 ` Paul Fulghum
2006-06-06 23:37 ` Krzysztof Halasa
2006-06-06 23:51 ` Randy.Dunlap
2006-06-06 23:56 ` Paul Fulghum
2006-06-07 0:12 ` Randy.Dunlap
2006-06-07 0:31 ` Paul Fulghum
2006-06-07 1:20 ` Remove patch from 2.6.17-rc5-mm3 Paul Fulghum
2006-06-07 0:42 ` [PATCH] fix missing hdlc symbols for synclink drivers Krzysztof Halasa
2006-06-07 1:09 ` Paul Fulghum
2006-06-06 23:11 ` Randy.Dunlap
2006-06-06 21:11 ` Krzysztof Halasa
2006-06-06 21:25 ` Randy.Dunlap
2006-06-06 8:03 ` 2.6.17-rc5-mm3 J.A. Magallón
2006-06-06 8:09 ` [patch, -rc5-mm3] lock validator: add local_irq_enable_in_hardirq() to ide-floppy.c Ingo Molnar
2006-06-05 16:30 2.6.17-rc5-mm3 Martin Bligh
2006-06-05 19:44 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-05 20:00 ` 2.6.17-rc5-mm3 Randy.Dunlap
2006-06-05 20:05 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-05 20:05 ` 2.6.17-rc5-mm3 Dave Jones
2006-06-05 20:08 ` 2.6.17-rc5-mm3 Ingo Molnar
2006-06-05 20:14 ` 2.6.17-rc5-mm3 Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060605191951.1ee122d3.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®