mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
	akpm@linux-foundation.org, ak@suse.de,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	asit.k.mallick@intel.com
Subject: Re: x86_64: potential critical issue with quicklists and page table pages
Date: Tue, 25 Sep 2007 10:09:28 +1000	[thread overview]
Message-ID: <1190678969.12382.7.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0709241438220.31469@schroedinger.engr.sgi.com>


On Mon, 2007-09-24 at 14:42 -0700, Christoph Lameter wrote:
> On Tue, 25 Sep 2007, Benjamin Herrenschmidt wrote:
> 
> > I'd suggest just reverting the patch for now (well, I see from the
> > commit list that you did just that) and I'll try to come up with
> > something better.
> 
> That would be great. Note that the reversal of the x86_64 quicklist 
> support patch does not address the issue that is (as pointed out by 
> Siddha) in core code and not in x86_64 arch dode. The fix that I posted 
> fixes the core issue.
> 
> > Christoph, I'd be happy if you didn't start butchering mmu_gather just
> > right now since I'm doing just that and it will collide all over the
> > place :-) Or if you want something specific done, please throw
> > ideas/patches at me and I'll integrate that in my serie.
> 
> Any "butchering" was done for 2.6.22. 2.6.23 only added arch support for 
> x86_64 since Andi forgot to merge it for .22. I'd be glad if you could 
> look into this and make quicklists interoperate nicely withh mmu gather.

I'll try, I'll let you know. Give me a few days to finish catching up
with backlog of things before i get back to it though.

Cheers,
Ben.



  reply	other threads:[~2007-09-25  0:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-21 18:07 Siddha, Suresh B
2007-09-21 18:18 ` Andi Kleen
2007-09-21 18:48 ` Linus Torvalds
2007-09-21 18:50   ` Christoph Lameter
2007-09-21 18:55     ` Linus Torvalds
2007-09-21 19:05       ` Linus Torvalds
2007-09-21 19:07         ` Christoph Lameter
2007-09-21 19:21           ` Linus Torvalds
2007-09-21 19:26             ` Christoph Lameter
2007-09-21 19:40               ` Linus Torvalds
2007-09-21 19:44                 ` Linus Torvalds
2007-09-21 19:56                 ` Christoph Lameter
2007-09-21 19:59                   ` Luck, Tony
2007-09-21 20:15                     ` Christoph Lameter
2007-09-24 21:27             ` Benjamin Herrenschmidt
2007-09-24 21:42               ` Christoph Lameter
2007-09-25  0:09                 ` Benjamin Herrenschmidt [this message]
2007-09-21 18:48 ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1190678969.12382.7.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=asit.k.mallick@intel.com \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®