From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: clameter@sgi.com, akpm@linux-foundation.org, ak@suse.de,
linux-kernel@vger.kernel.org, tony.luck@intel.com,
asit.k.mallick@intel.com
Subject: Re: x86_64: potential critical issue with quicklists and page table pages
Date: Fri, 21 Sep 2007 11:48:55 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0709211139550.16478@woody.linux-foundation.org> (raw)
In-Reply-To: <20070921180742.GH20863@linux-os.sc.intel.com>
On Fri, 21 Sep 2007, Siddha, Suresh B wrote:
>
> git commit 34feb2c83beb3bdf13535a36770f7e50b47ef299 started using quicklists
> for freeing page table pages and removed the usage of tlb_remove_page()
>
> And looking at quicklist_free() and quicklist_free_page(), on a NUMA platform,
> this can potentially free the page before the corresponding TLB caches
> are flushed.
Hmm? We only add them to the quicklists in the exact same places where we
*used* to just free them entirely. So I don't see why semantics would have
changed..
> Can we revert this commit for 2.6.23 and look at this code post 2.6.23?
I'll happily revert it, but I want to understand this better, so more of
an explanation of the codepath that actually does something wrong, please.
Linus
next prev parent reply other threads:[~2007-09-21 18:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 18:07 Siddha, Suresh B
2007-09-21 18:18 ` Andi Kleen
2007-09-21 18:48 ` Linus Torvalds [this message]
2007-09-21 18:50 ` Christoph Lameter
2007-09-21 18:55 ` Linus Torvalds
2007-09-21 19:05 ` Linus Torvalds
2007-09-21 19:07 ` Christoph Lameter
2007-09-21 19:21 ` Linus Torvalds
2007-09-21 19:26 ` Christoph Lameter
2007-09-21 19:40 ` Linus Torvalds
2007-09-21 19:44 ` Linus Torvalds
2007-09-21 19:56 ` Christoph Lameter
2007-09-21 19:59 ` Luck, Tony
2007-09-21 20:15 ` Christoph Lameter
2007-09-24 21:27 ` Benjamin Herrenschmidt
2007-09-24 21:42 ` Christoph Lameter
2007-09-25 0:09 ` Benjamin Herrenschmidt
2007-09-21 18:48 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0709211139550.16478@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=asit.k.mallick@intel.com \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®