mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
	ak@suse.de, linux-kernel@vger.kernel.org, tony.luck@intel.com,
	asit.k.mallick@intel.com
Subject: Re: x86_64: potential critical issue with quicklists and page table pages
Date: Fri, 21 Sep 2007 11:48:58 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0709211145520.17160@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20070921180742.GH20863@linux-os.sc.intel.com>

On Fri, 21 Sep 2007, Siddha, Suresh B wrote:

> Essentially quicklist free routines are doing something like
> __quicklist_free()
> 	...
> 	if (unlikely(nid != numa_node_id())) {
> 		__free_page(page);
> 		...
> 	}
> 
> 	....
> 
> 
> Now this will potentially cause a problem, if a cpu in someother node starts
> using this page, while the corresponding TLB entries are still alive
> in the original cpu which is still freeing the page table pages.

Hmmm... Yes could be.

> This potentially can cause SW failures and hard to debug issues like
> http://www.ussg.iu.edu/hypermail/linux/kernel/0205.2/1254.html

Cannot get to this page:

Not Found

The requested URL /hypermail/linux/kernel/0205.2/1254.htm was not found on 
this server.


> Can we revert this commit for 2.6.23 and look at this code post 2.6.23?

We can remove this piece alone since it was an optimization.

---
 include/linux/quicklist.h |    7 -------
 1 file changed, 7 deletions(-)

Index: linux-2.6/include/linux/quicklist.h
===================================================================
--- linux-2.6.orig/include/linux/quicklist.h	2007-09-21 11:46:44.000000000 -0700
+++ linux-2.6/include/linux/quicklist.h	2007-09-21 11:47:01.000000000 -0700
@@ -58,13 +58,6 @@ static inline void __quicklist_free(int 
 	struct quicklist *q;
 	int nid = page_to_nid(page);
 
-	if (unlikely(nid != numa_node_id())) {
-		if (dtor)
-			dtor(p);
-		__free_page(page);
-		return;
-	}
-
 	q = &get_cpu_var(quicklist)[nr];
 	*(void **)p = q->page;
 	q->page = p;

      parent reply	other threads:[~2007-09-21 18:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-21 18:07 Siddha, Suresh B
2007-09-21 18:18 ` Andi Kleen
2007-09-21 18:48 ` Linus Torvalds
2007-09-21 18:50   ` Christoph Lameter
2007-09-21 18:55     ` Linus Torvalds
2007-09-21 19:05       ` Linus Torvalds
2007-09-21 19:07         ` Christoph Lameter
2007-09-21 19:21           ` Linus Torvalds
2007-09-21 19:26             ` Christoph Lameter
2007-09-21 19:40               ` Linus Torvalds
2007-09-21 19:44                 ` Linus Torvalds
2007-09-21 19:56                 ` Christoph Lameter
2007-09-21 19:59                   ` Luck, Tony
2007-09-21 20:15                     ` Christoph Lameter
2007-09-24 21:27             ` Benjamin Herrenschmidt
2007-09-24 21:42               ` Christoph Lameter
2007-09-25  0:09                 ` Benjamin Herrenschmidt
2007-09-21 18:48 ` Christoph Lameter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0709211145520.17160@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=asit.k.mallick@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®