mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
To: ralf@linux-mips.org, linux-mips@linux-mips.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 02/17] [MIPS] Malta: use the KERN_ facility level in printk()
Date: Thu, 24 Jan 2008 19:52:42 +0300	[thread overview]
Message-ID: <1201193577-4261-3-git-send-email-dmitri.vorobiev@gmail.com> (raw)
In-Reply-To: <1201193577-4261-1-git-send-email-dmitri.vorobiev@gmail.com>

This patch adds the KERN_ macros to printk() calls. Where applicable,
spaces are replaced by tabs.

These changes noticeably reduce the number of errors and warnings
reported by the checkpatch.pl script for the malta_int.c file.

Before the patch: total: 47 errors, 20 warnings, 354 lines checked

After the patch: total: 34 errors, 7 warnings, 355 lines checked

No functional changes introduced.

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
---
 arch/mips/mips-boards/malta/malta_int.c |   27 ++++++++++++++-------------
 1 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/arch/mips/mips-boards/malta/malta_int.c b/arch/mips/mips-boards/malta/malta_int.c
index f010261..2483b40 100644
--- a/arch/mips/mips-boards/malta/malta_int.c
+++ b/arch/mips/mips-boards/malta/malta_int.c
@@ -83,7 +83,7 @@ static inline int mips_pcibios_iack(void)
 		BONITO_PCIMAP_CFG = 0;
 		break;
 	default:
-	        printk("Unknown system controller.\n");
+		printk(KERN_WARNING "Unknown system controller.\n");
 		return -1;
 	}
 	return irq;
@@ -127,8 +127,8 @@ static void corehi_irqdispatch(void)
 	unsigned int intrcause, datalo, datahi;
 	struct pt_regs *regs = get_irq_regs();
 
-        printk("CoreHI interrupt, shouldn't happen, so we die here!!!\n");
-        printk("epc   : %08lx\nStatus: %08lx\n"
+	printk(KERN_EMERG "CoreHI interrupt, shouldn't happen, we die here!\n");
+	printk(KERN_EMERG "epc   : %08lx\nStatus: %08lx\n"
 	       "Cause : %08lx\nbadVaddr : %08lx\n",
 	       regs->cp0_epc, regs->cp0_status,
 	       regs->cp0_cause, regs->cp0_badvaddr);
@@ -149,8 +149,9 @@ static void corehi_irqdispatch(void)
                 intrcause = GT_READ(GT_INTRCAUSE_OFS);
                 datalo = GT_READ(GT_CPUERR_ADDRLO_OFS);
                 datahi = GT_READ(GT_CPUERR_ADDRHI_OFS);
-                printk("GT_INTRCAUSE = %08x\n", intrcause);
-                printk("GT_CPUERR_ADDR = %02x%08x\n", datahi, datalo);
+		printk(KERN_EMERG "GT_INTRCAUSE = %08x\n", intrcause);
+		printk(KERN_EMERG "GT_CPUERR_ADDR = %02x%08x\n",
+				datahi, datalo);
                 break;
         case MIPS_REVISION_SCON_BONITO:
                 pcibadaddr = BONITO_PCIBADADDR;
@@ -161,14 +162,14 @@ static void corehi_irqdispatch(void)
                 intedge = BONITO_INTEDGE;
                 intsteer = BONITO_INTSTEER;
                 pcicmd = BONITO_PCICMD;
-                printk("BONITO_INTISR = %08x\n", intisr);
-                printk("BONITO_INTEN = %08x\n", inten);
-                printk("BONITO_INTPOL = %08x\n", intpol);
-                printk("BONITO_INTEDGE = %08x\n", intedge);
-                printk("BONITO_INTSTEER = %08x\n", intsteer);
-                printk("BONITO_PCICMD = %08x\n", pcicmd);
-                printk("BONITO_PCIBADADDR = %08x\n", pcibadaddr);
-                printk("BONITO_PCIMSTAT = %08x\n", pcimstat);
+		printk(KERN_EMERG "BONITO_INTISR = %08x\n", intisr);
+		printk(KERN_EMERG "BONITO_INTEN = %08x\n", inten);
+		printk(KERN_EMERG "BONITO_INTPOL = %08x\n", intpol);
+		printk(KERN_EMERG "BONITO_INTEDGE = %08x\n", intedge);
+		printk(KERN_EMERG "BONITO_INTSTEER = %08x\n", intsteer);
+		printk(KERN_EMERG "BONITO_PCICMD = %08x\n", pcicmd);
+		printk(KERN_EMERG "BONITO_PCIBADADDR = %08x\n", pcibadaddr);
+		printk(KERN_EMERG "BONITO_PCIMSTAT = %08x\n", pcimstat);
                 break;
         }
 
-- 
1.5.3


  parent reply	other threads:[~2008-01-24 16:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-24 16:52 [PATCH 00/17] [MIPS] Malta: massive code cleanup Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 01/17] [MIPS] Malta: use Linux kernel style for structure initialization Dmitri Vorobiev
2008-01-24 16:52 ` Dmitri Vorobiev [this message]
2008-01-24 16:52 ` [PATCH 03/17] [MIPS] Malta: check the PCI clock frequency in a separate function Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 04/17] [MIPS] Malta: set up the screen info " Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 05/17] [MIPS] Malta: use tabs not spaces Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 06/17] [MIPS] Malta: remove a dead function declaration Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 07/17] [MIPS] Malta: fix oversized lines in malta_int.c Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 08/17] [MIPS] Malta, Atlas, Sead: remove an extern from .c files Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 09/17] [MIPS] Malta: include <linux/cpu.h> instead of <asm/cpu.h> Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 10/17] [MIPS] Malta: remove a superfluous comment Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 11/17] [MIPS] Malta: else should follow close brace in malta_int.c Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 12/17] [MIPS] Malta: Use C89 style for comments Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 13/17] [MIPS] Malta, Atlas: move an extern function declaration to the header file Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 14/17] [MIPS] Malta: fix braces at single statement blocks Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 15/17] [MIPS] Malta: make the helper function static Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 16/17] [MIPS] Malta: remaining bits of the board support code cleanup Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 17/17] [MIPS] remove Documentation/mips/GT64120.README Dmitri Vorobiev
2008-01-28 14:33 ` [PATCH 00/17] [MIPS] Malta: massive code cleanup Ralf Baechle
2008-01-28 14:36   ` Dmitri Vorobiev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201193577-4261-3-git-send-email-dmitri.vorobiev@gmail.com \
    --to=dmitri.vorobiev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome