mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
To: ralf@linux-mips.org, linux-mips@linux-mips.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 04/17] [MIPS] Malta: set up the screen info in a separate function
Date: Thu, 24 Jan 2008 19:52:44 +0300	[thread overview]
Message-ID: <1201193577-4261-5-git-send-email-dmitri.vorobiev@gmail.com> (raw)
In-Reply-To: <1201193577-4261-1-git-send-email-dmitri.vorobiev@gmail.com>

This patch adds a separate short and sweet function to initialize
the screen_info global variable.

This improves readability of the Malta board setup code.

No functional changes introduced.

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
---
 arch/mips/mips-boards/malta/malta_setup.c |   39 ++++++++++++++++------------
 1 files changed, 22 insertions(+), 17 deletions(-)

diff --git a/arch/mips/mips-boards/malta/malta_setup.c b/arch/mips/mips-boards/malta/malta_setup.c
index 79d74ea..8b391ee 100644
--- a/arch/mips/mips-boards/malta/malta_setup.c
+++ b/arch/mips/mips-boards/malta/malta_setup.c
@@ -132,6 +132,26 @@ static void __init pci_clock_check(void)
 }
 #endif
 
+#if defined(CONFIG_VT) && defined(CONFIG_VGA_CONSOLE)
+static void __init screen_info_setup(void)
+{
+	screen_info = (struct screen_info) {
+		.orig_x = 0,
+		.orig_y = 25,
+		.ext_mem_k = 0,
+		.orig_video_page = 0,
+		.orig_video_mode = 0,
+		.orig_video_cols = 80,
+		.unused2 = 0,
+		.orig_video_ega_bx = 0,
+		.unused3 = 0,
+		.orig_video_lines = 25,
+		.orig_video_isVGA = VIDEO_TYPE_VGAC,
+		.orig_video_points = 16
+	};
+}
+#endif
+
 void __init plat_mem_setup(void)
 {
 	unsigned int i;
@@ -200,23 +220,8 @@ void __init plat_mem_setup(void)
 #ifdef CONFIG_BLK_DEV_FD
 	fd_activate();
 #endif
-#ifdef CONFIG_VT
-#if defined(CONFIG_VGA_CONSOLE)
-	screen_info = (struct screen_info) {
-		.orig_x = 0,
-		.orig_y = 25,
-		.ext_mem_k = 0,
-		.orig_video_page = 0,
-		.orig_video_mode = 0,
-		.orig_video_cols = 80,
-		.unused2 = 0,
-		.orig_video_ega_bx = 0,
-		.unused3 = 0,
-		.orig_video_lines = 25,
-		.orig_video_isVGA = VIDEO_TYPE_VGAC,
-		.orig_video_points = 16
-	};
-#endif
+#if defined(CONFIG_VT) && defined(CONFIG_VGA_CONSOLE)
+	screen_info_setup();
 #endif
 	mips_reboot_setup();
 }
-- 
1.5.3


  parent reply	other threads:[~2008-01-24 16:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-24 16:52 [PATCH 00/17] [MIPS] Malta: massive code cleanup Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 01/17] [MIPS] Malta: use Linux kernel style for structure initialization Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 02/17] [MIPS] Malta: use the KERN_ facility level in printk() Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 03/17] [MIPS] Malta: check the PCI clock frequency in a separate function Dmitri Vorobiev
2008-01-24 16:52 ` Dmitri Vorobiev [this message]
2008-01-24 16:52 ` [PATCH 05/17] [MIPS] Malta: use tabs not spaces Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 06/17] [MIPS] Malta: remove a dead function declaration Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 07/17] [MIPS] Malta: fix oversized lines in malta_int.c Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 08/17] [MIPS] Malta, Atlas, Sead: remove an extern from .c files Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 09/17] [MIPS] Malta: include <linux/cpu.h> instead of <asm/cpu.h> Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 10/17] [MIPS] Malta: remove a superfluous comment Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 11/17] [MIPS] Malta: else should follow close brace in malta_int.c Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 12/17] [MIPS] Malta: Use C89 style for comments Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 13/17] [MIPS] Malta, Atlas: move an extern function declaration to the header file Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 14/17] [MIPS] Malta: fix braces at single statement blocks Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 15/17] [MIPS] Malta: make the helper function static Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 16/17] [MIPS] Malta: remaining bits of the board support code cleanup Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 17/17] [MIPS] remove Documentation/mips/GT64120.README Dmitri Vorobiev
2008-01-28 14:33 ` [PATCH 00/17] [MIPS] Malta: massive code cleanup Ralf Baechle
2008-01-28 14:36   ` Dmitri Vorobiev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201193577-4261-5-git-send-email-dmitri.vorobiev@gmail.com \
    --to=dmitri.vorobiev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome