From: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
To: ralf@linux-mips.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 08/17] [MIPS] Malta, Atlas, Sead: remove an extern from .c files
Date: Thu, 24 Jan 2008 19:52:48 +0300 [thread overview]
Message-ID: <1201193577-4261-9-git-send-email-dmitri.vorobiev@gmail.com> (raw)
In-Reply-To: <1201193577-4261-1-git-send-email-dmitri.vorobiev@gmail.com>
This patch moves the "extern" declaration for the function
mips_reboot_setup() from the board setup .c files to the
header file include/asm-mips/mips-boards/generic.h.
This fixes a warning produced by the checkpatch.pl script.
No functional changes introduced.
This was compile-tested by building the kernel for all
three boards affected by this change. All builds finished
successfully.
Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
---
arch/mips/mips-boards/atlas/atlas_setup.c | 2 --
arch/mips/mips-boards/malta/malta_setup.c | 2 --
arch/mips/mips-boards/sead/sead_setup.c | 2 --
include/asm-mips/mips-boards/generic.h | 2 ++
4 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/mips/mips-boards/atlas/atlas_setup.c b/arch/mips/mips-boards/atlas/atlas_setup.c
index e405d11..5ce8004 100644
--- a/arch/mips/mips-boards/atlas/atlas_setup.c
+++ b/arch/mips/mips-boards/atlas/atlas_setup.c
@@ -34,8 +34,6 @@
#include <asm/time.h>
#include <asm/traps.h>
-extern void mips_reboot_setup(void);
-
#ifdef CONFIG_KGDB
extern void kgdb_config(void);
#endif
diff --git a/arch/mips/mips-boards/malta/malta_setup.c b/arch/mips/mips-boards/malta/malta_setup.c
index 480521f..e5ac079 100644
--- a/arch/mips/mips-boards/malta/malta_setup.c
+++ b/arch/mips/mips-boards/malta/malta_setup.c
@@ -35,8 +35,6 @@
#include <linux/console.h>
#endif
-extern void mips_reboot_setup(void);
-
#ifdef CONFIG_KGDB
extern void kgdb_config(void);
#endif
diff --git a/arch/mips/mips-boards/sead/sead_setup.c b/arch/mips/mips-boards/sead/sead_setup.c
index 1fb61b8..8aa8e5b 100644
--- a/arch/mips/mips-boards/sead/sead_setup.c
+++ b/arch/mips/mips-boards/sead/sead_setup.c
@@ -34,8 +34,6 @@
#include <asm/mips-boards/seadint.h>
#include <asm/time.h>
-extern void mips_reboot_setup(void);
-
static void __init serial_init(void);
const char *get_system_type(void)
diff --git a/include/asm-mips/mips-boards/generic.h b/include/asm-mips/mips-boards/generic.h
index d589774..2ca6bda 100644
--- a/include/asm-mips/mips-boards/generic.h
+++ b/include/asm-mips/mips-boards/generic.h
@@ -97,6 +97,8 @@ extern int mips_revision_corid;
extern int mips_revision_sconid;
+extern void mips_reboot_setup(void);
+
#ifdef CONFIG_PCI
extern void mips_pcibios_init(void);
#else
--
1.5.3
next prev parent reply other threads:[~2008-01-24 16:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 16:52 [PATCH 00/17] [MIPS] Malta: massive code cleanup Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 01/17] [MIPS] Malta: use Linux kernel style for structure initialization Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 02/17] [MIPS] Malta: use the KERN_ facility level in printk() Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 03/17] [MIPS] Malta: check the PCI clock frequency in a separate function Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 04/17] [MIPS] Malta: set up the screen info " Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 05/17] [MIPS] Malta: use tabs not spaces Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 06/17] [MIPS] Malta: remove a dead function declaration Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 07/17] [MIPS] Malta: fix oversized lines in malta_int.c Dmitri Vorobiev
2008-01-24 16:52 ` Dmitri Vorobiev [this message]
2008-01-24 16:52 ` [PATCH 09/17] [MIPS] Malta: include <linux/cpu.h> instead of <asm/cpu.h> Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 10/17] [MIPS] Malta: remove a superfluous comment Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 11/17] [MIPS] Malta: else should follow close brace in malta_int.c Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 12/17] [MIPS] Malta: Use C89 style for comments Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 13/17] [MIPS] Malta, Atlas: move an extern function declaration to the header file Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 14/17] [MIPS] Malta: fix braces at single statement blocks Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 15/17] [MIPS] Malta: make the helper function static Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 16/17] [MIPS] Malta: remaining bits of the board support code cleanup Dmitri Vorobiev
2008-01-24 16:52 ` [PATCH 17/17] [MIPS] remove Documentation/mips/GT64120.README Dmitri Vorobiev
2008-01-28 14:33 ` [PATCH 00/17] [MIPS] Malta: massive code cleanup Ralf Baechle
2008-01-28 14:36 ` Dmitri Vorobiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201193577-4261-9-git-send-email-dmitri.vorobiev@gmail.com \
--to=dmitri.vorobiev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome