mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Glauber Costa <gcosta@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, glommer@gmail.com, mingo@elte.hu,
	pzijlstr@redhat.com, arjan@infradead.org
Subject: [PATCH 0/2] onlining cpus can break lockdep
Date: Thu, 21 Feb 2008 17:40:54 -0300	[thread overview]
Message-ID: <1203626456-3101-1-git-send-email-gcosta@redhat.com> (raw)

Hi,

While testing with hotplugging cpus today, I've came across a stack
trace generated by lockdep. The reason for that is that
do_boot_cpu() in smpboot_64.c ends up initializing a struct work_struct
variable in the stack.

These patches fix this by making it static. a per-cpu variable is choosen,
since, to the best of my knowledge, nothing prevents two cpus going up
at the same time, and so a single static c_idle won't do.

I separated it in two patches to better isolate the change. The first patch
just paves the way, by turning access to c_idle into pointer dereferences.
The second one does the real work.

Thanks



             reply	other threads:[~2008-02-21 20:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 20:40 Glauber Costa [this message]
2008-02-21 20:40 ` [PATCH 1/2] turn c_idle into a pointer Glauber Costa
2008-02-21 20:40   ` [PATCH 2/2] make work have a static address in do_boot_cpu() Glauber Costa
2008-02-21 22:12     ` Peter Zijlstra
2008-02-21 22:57       ` Glauber Costa
2008-02-22  9:46         ` Ingo Molnar
2008-02-21 21:12 ` [PATCH 0/2] onlining cpus can break lockdep Ingo Molnar
2008-02-21 21:17   ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203626456-3101-1-git-send-email-gcosta@redhat.com \
    --to=gcosta@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=glommer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pzijlstr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®