From: Ingo Molnar <mingo@elte.hu>
To: Glauber Costa <glommer@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Glauber Costa <gcosta@redhat.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
arjan@infradead.org
Subject: Re: [PATCH 2/2] make work have a static address in do_boot_cpu()
Date: Fri, 22 Feb 2008 10:46:28 +0100 [thread overview]
Message-ID: <20080222094628.GB6269@elte.hu> (raw)
In-Reply-To: <5d6222a80802211457s2beb4d5cre331bc800c28d111@mail.gmail.com>
* Glauber Costa <glommer@gmail.com> wrote:
> > Looks way overkill. Doesn't something like:
> > > struct create_idle create_idle = {
> > > - .work = __WORK_INITIALIZER(create_idle.work, do_fork_idle),
> > > .cpu = cpu,
> > > .done = COMPLETION_INITIALIZER_ONSTACK(create_idle.done),
> > > };
> > > + INIT_WORK(&create_idle.work, do_fork_idle);
> >
> > work?
>
> Indeed.
>
> I missed the static lock_class_key definition inside INIT_WORK macro.
> It does the job neatly.
could you resend the updated patch?
Ingo
next prev parent reply other threads:[~2008-02-22 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 20:40 [PATCH 0/2] onlining cpus can break lockdep Glauber Costa
2008-02-21 20:40 ` [PATCH 1/2] turn c_idle into a pointer Glauber Costa
2008-02-21 20:40 ` [PATCH 2/2] make work have a static address in do_boot_cpu() Glauber Costa
2008-02-21 22:12 ` Peter Zijlstra
2008-02-21 22:57 ` Glauber Costa
2008-02-22 9:46 ` Ingo Molnar [this message]
2008-02-21 21:12 ` [PATCH 0/2] onlining cpus can break lockdep Ingo Molnar
2008-02-21 21:17 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080222094628.GB6269@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=gcosta@redhat.com \
--cc=glommer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®