From: Glauber Costa <gcosta@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, glommer@gmail.com, mingo@elte.hu,
pzijlstr@redhat.com, arjan@infradead.org,
Glauber Costa <gcosta@redhat.com>
Subject: [PATCH 2/2] make work have a static address in do_boot_cpu()
Date: Thu, 21 Feb 2008 17:40:56 -0300 [thread overview]
Message-ID: <1203626456-3101-3-git-send-email-gcosta@redhat.com> (raw)
In-Reply-To: <1203626456-3101-2-git-send-email-gcosta@redhat.com>
This patch makes the work field in create_idle have
a static address. Otherwise, being a stack variable, it can
boild down the lockdep system.
Signed-off-by: Glauber Costa <gcosta@redhat.com>
---
arch/x86/kernel/smpboot_64.c | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/smpboot_64.c b/arch/x86/kernel/smpboot_64.c
index f15b774..d79b7a8 100644
--- a/arch/x86/kernel/smpboot_64.c
+++ b/arch/x86/kernel/smpboot_64.c
@@ -545,6 +545,7 @@ static void __cpuinit do_fork_idle(struc
complete(&c_idle->done);
}
+static DEFINE_PER_CPU(struct create_idle, cpu_idle);
/*
* Boot one CPU.
*/
@@ -553,12 +554,12 @@ static int __cpuinit do_boot_cpu(int cpu
unsigned long boot_error;
int timeout;
unsigned long start_rip;
- struct create_idle create_idle = {
- .work = __WORK_INITIALIZER(create_idle.work, do_fork_idle),
- .cpu = cpu,
- .done = COMPLETION_INITIALIZER_ONSTACK(create_idle.done),
- };
- struct create_idle *c_idle = &create_idle;
+ struct create_idle *c_idle = &per_cpu(cpu_idle, cpu);
+ struct work_struct *c_idle_work = &c_idle->work;
+
+ INIT_WORK(c_idle_work, do_fork_idle);
+ c_idle->cpu = cpu;
+ init_completion(&c_idle->done);
/* allocate memory for gdts of secondary cpus. Hotplug is considered */
if (!cpu_gdt_descr[cpu].address &&
--
1.4.2
next prev parent reply other threads:[~2008-02-21 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 20:40 [PATCH 0/2] onlining cpus can break lockdep Glauber Costa
2008-02-21 20:40 ` [PATCH 1/2] turn c_idle into a pointer Glauber Costa
2008-02-21 20:40 ` Glauber Costa [this message]
2008-02-21 22:12 ` [PATCH 2/2] make work have a static address in do_boot_cpu() Peter Zijlstra
2008-02-21 22:57 ` Glauber Costa
2008-02-22 9:46 ` Ingo Molnar
2008-02-21 21:12 ` [PATCH 0/2] onlining cpus can break lockdep Ingo Molnar
2008-02-21 21:17 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203626456-3101-3-git-send-email-gcosta@redhat.com \
--to=gcosta@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=glommer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pzijlstr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®