From: Glauber Costa <gcosta@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, glommer@gmail.com, mingo@elte.hu,
pzijlstr@redhat.com, arjan@infradead.org,
Glauber Costa <gcosta@redhat.com>
Subject: [PATCH 1/2] turn c_idle into a pointer
Date: Thu, 21 Feb 2008 17:40:55 -0300 [thread overview]
Message-ID: <1203626456-3101-2-git-send-email-gcosta@redhat.com> (raw)
In-Reply-To: <1203626456-3101-1-git-send-email-gcosta@redhat.com>
This is not useful by itself, but part of making the
underlying work_struct have a static address.
Signed-off-by: Glauber Costa <gcosta@redhat.com>
---
arch/x86/kernel/smpboot_64.c | 37 +++++++++++++++++++------------------
1 files changed, 19 insertions(+), 18 deletions(-)
diff --git a/arch/x86/kernel/smpboot_64.c b/arch/x86/kernel/smpboot_64.c
index d53bd6f..f15b774 100644
--- a/arch/x86/kernel/smpboot_64.c
+++ b/arch/x86/kernel/smpboot_64.c
@@ -553,11 +553,12 @@ static int __cpuinit do_boot_cpu(int cpu
unsigned long boot_error;
int timeout;
unsigned long start_rip;
- struct create_idle c_idle = {
- .work = __WORK_INITIALIZER(c_idle.work, do_fork_idle),
+ struct create_idle create_idle = {
+ .work = __WORK_INITIALIZER(create_idle.work, do_fork_idle),
.cpu = cpu,
- .done = COMPLETION_INITIALIZER_ONSTACK(c_idle.done),
+ .done = COMPLETION_INITIALIZER_ONSTACK(create_idle.done),
};
+ struct create_idle *c_idle = &create_idle;
/* allocate memory for gdts of secondary cpus. Hotplug is considered */
if (!cpu_gdt_descr[cpu].address &&
@@ -584,12 +585,12 @@ static int __cpuinit do_boot_cpu(int cpu
alternatives_smp_switch(1);
- c_idle.idle = get_idle_for_cpu(cpu);
+ c_idle->idle = get_idle_for_cpu(cpu);
- if (c_idle.idle) {
- c_idle.idle->thread.sp = (unsigned long) (((struct pt_regs *)
- (THREAD_SIZE + task_stack_page(c_idle.idle))) - 1);
- init_idle(c_idle.idle, cpu);
+ if (c_idle->idle) {
+ c_idle->idle->thread.sp = (unsigned long) (((struct pt_regs *)
+ (THREAD_SIZE + task_stack_page(c_idle->idle))) - 1);
+ init_idle(c_idle->idle, cpu);
goto do_rest;
}
@@ -604,29 +605,29 @@ static int __cpuinit do_boot_cpu(int cpu
* thread.
*/
if (!keventd_up() || current_is_keventd())
- c_idle.work.func(&c_idle.work);
+ c_idle->work.func(&c_idle->work);
else {
- schedule_work(&c_idle.work);
- wait_for_completion(&c_idle.done);
+ schedule_work(&c_idle->work);
+ wait_for_completion(&c_idle->done);
}
- if (IS_ERR(c_idle.idle)) {
+ if (IS_ERR(c_idle->idle)) {
printk("failed fork for CPU %d\n", cpu);
- return PTR_ERR(c_idle.idle);
+ return PTR_ERR(c_idle->idle);
}
- set_idle_for_cpu(cpu, c_idle.idle);
+ set_idle_for_cpu(cpu, c_idle->idle);
do_rest:
- cpu_pda(cpu)->pcurrent = c_idle.idle;
+ cpu_pda(cpu)->pcurrent = c_idle->idle;
start_rip = setup_trampoline();
- init_rsp = c_idle.idle->thread.sp;
- load_sp0(&per_cpu(init_tss, cpu), &c_idle.idle->thread);
+ init_rsp = c_idle->idle->thread.sp;
+ load_sp0(&per_cpu(init_tss, cpu), &c_idle->idle->thread);
initial_code = start_secondary;
- clear_tsk_thread_flag(c_idle.idle, TIF_FORK);
+ clear_tsk_thread_flag(c_idle->idle, TIF_FORK);
printk(KERN_INFO "Booting processor %d/%d APIC 0x%x\n", cpu,
cpus_weight(cpu_present_map),
--
1.4.2
next prev parent reply other threads:[~2008-02-21 20:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 20:40 [PATCH 0/2] onlining cpus can break lockdep Glauber Costa
2008-02-21 20:40 ` Glauber Costa [this message]
2008-02-21 20:40 ` [PATCH 2/2] make work have a static address in do_boot_cpu() Glauber Costa
2008-02-21 22:12 ` Peter Zijlstra
2008-02-21 22:57 ` Glauber Costa
2008-02-22 9:46 ` Ingo Molnar
2008-02-21 21:12 ` [PATCH 0/2] onlining cpus can break lockdep Ingo Molnar
2008-02-21 21:17 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203626456-3101-2-git-send-email-gcosta@redhat.com \
--to=gcosta@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=glommer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pzijlstr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome