From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk, linux-kernel@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>, Jeff Dike <jdike@linux.intel.com>
Subject: [PATCH 13/14] ubd: simplify block request completion
Date: Fri, 13 Mar 2009 14:02:57 +0900 [thread overview]
Message-ID: <1236920578-2179-14-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1236920578-2179-1-git-send-email-tj@kernel.org>
Impact: cleanup
ubd had its own block request partial completion mechanism, which is
unnecessary as block layer already does it. Kill ubd_end_request()
and ubd_finish() and replace them with direct call to
blk_end_request().
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Jeff Dike <jdike@linux.intel.com>
---
arch/um/drivers/ubd_kern.c | 23 +----------------------
1 files changed, 1 insertions(+), 22 deletions(-)
diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index 0a86811..906ecdf 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -451,23 +451,6 @@ static void do_ubd_request(struct request_queue * q);
/* Only changed by ubd_init, which is an initcall. */
static int thread_fd = -1;
-
-static void ubd_end_request(struct request *req, int bytes, int error)
-{
- blk_end_request(req, error, bytes);
-}
-
-/* Callable only from interrupt context - otherwise you need to do
- * spin_lock_irq()/spin_lock_irqsave() */
-static inline void ubd_finish(struct request *req, int bytes)
-{
- if(bytes < 0){
- ubd_end_request(req, 0, -EIO);
- return;
- }
- ubd_end_request(req, bytes, 0);
-}
-
static LIST_HEAD(restart);
/* XXX - move this inside ubd_intr. */
@@ -475,7 +458,6 @@ static LIST_HEAD(restart);
static void ubd_handler(void)
{
struct io_thread_req *req;
- struct request *rq;
struct ubd *ubd;
struct list_head *list, *next_ele;
unsigned long flags;
@@ -492,10 +474,7 @@ static void ubd_handler(void)
return;
}
- rq = req->req;
- rq->nr_sectors -= req->length >> 9;
- if(rq->nr_sectors == 0)
- ubd_finish(rq, rq->hard_nr_sectors << 9);
+ blk_end_request(req->req, 0, req->length);
kfree(req);
}
reactivate_fd(thread_fd, UBD_IRQ);
--
1.6.0.2
next prev parent reply other threads:[~2009-03-13 5:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 5:02 [GIT PATCH] block: cleanup patches Tejun Heo
2009-03-13 5:02 ` [PATCH 01/14] block: merge blk_invoke_request_fn() into __blk_run_queue() Tejun Heo
2009-03-13 5:02 ` [PATCH 02/14] block: kill blk_start_queueing() Tejun Heo
2009-03-13 5:02 ` [PATCH 03/14] block: don't set REQ_NOMERGE unnecessarily Tejun Heo
2009-03-13 5:02 ` [PATCH 04/14] block: cleanup REQ_SOFTBARRIER usages Tejun Heo
2009-03-13 5:02 ` [PATCH 05/14] block: clean up misc stuff after block layer timeout conversion Tejun Heo
2009-03-13 5:02 ` [PATCH 06/14] block: reorder request completion functions Tejun Heo
2009-03-13 5:02 ` [PATCH 07/14] block: reorganize request fetching functions Tejun Heo
2009-03-13 5:02 ` [PATCH 08/14] block: kill blk_end_request_callback() Tejun Heo
2009-03-13 5:02 ` [PATCH 09/14] block: clean up request completion API Tejun Heo
2009-03-16 9:12 ` Boaz Harrosh
2009-03-16 9:45 ` Tejun Heo
2009-03-13 5:02 ` [PATCH 10/14] block: move rq->start_time initialization to blk_rq_init() Tejun Heo
2009-03-13 5:02 ` [PATCH 11/14] block: implement and use [__]blk_end_request_all() Tejun Heo
2009-03-13 19:21 ` Bartlomiej Zolnierkiewicz
2009-03-14 1:56 ` Tejun Heo
2009-03-14 2:10 ` Tejun Heo
2009-03-14 19:23 ` Bartlomiej Zolnierkiewicz
2009-03-14 19:56 ` James Bottomley
2009-03-14 20:19 ` Bartlomiej Zolnierkiewicz
2009-03-15 16:48 ` Jens Axboe
2009-03-15 17:40 ` Bartlomiej Zolnierkiewicz
2009-03-15 18:39 ` Jens Axboe
2009-03-15 20:34 ` Bartlomiej Zolnierkiewicz
2009-03-15 20:48 ` Jens Axboe
2009-03-15 21:34 ` Bartlomiej Zolnierkiewicz
2009-03-16 1:39 ` Tejun Heo
2009-03-13 5:02 ` [PATCH 12/14] block: kill end_request() Tejun Heo
2009-03-13 5:02 ` Tejun Heo [this message]
2009-03-13 5:02 ` [PATCH 14/14] block: clean up unnecessary stuff from block drivers Tejun Heo
2009-03-14 2:00 ` [GIT PATCH] block: cleanup patches Tejun Heo
2009-03-15 16:45 ` Jens Axboe
2009-03-16 1:15 ` Tejun Heo
2009-03-16 7:22 ` Jens Axboe
2009-03-16 7:53 ` Tejun Heo
2009-03-16 7:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236920578-2179-14-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=jdike@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome