From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk, linux-kernel@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>
Subject: [PATCH 04/14] block: cleanup REQ_SOFTBARRIER usages
Date: Fri, 13 Mar 2009 14:02:48 +0900 [thread overview]
Message-ID: <1236920578-2179-5-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1236920578-2179-1-git-send-email-tj@kernel.org>
Impact: cleanup
Low level drivers don't need to worry about REQ_SOFTBARRIER, either
does blk_insert_request(). Don't set it there. It doesn't cause
malfunction but is confusing. After this, REQ_SOFTBARRIER is used
only in elevator proper and for discard requests.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
block/blk-core.c | 1 -
drivers/ide/ide-disk.c | 1 -
drivers/ide/ide-ioctls.c | 1 -
3 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index d7b2cc9..9e5f154 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -944,7 +944,6 @@ void blk_insert_request(struct request_queue *q, struct request *rq,
* barrier
*/
rq->cmd_type = REQ_TYPE_SPECIAL;
- rq->cmd_flags |= REQ_SOFTBARRIER;
rq->special = data;
diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c
index 806760d..0cd287d 100644
--- a/drivers/ide/ide-disk.c
+++ b/drivers/ide/ide-disk.c
@@ -405,7 +405,6 @@ static void idedisk_prepare_flush(struct request_queue *q, struct request *rq)
task->data_phase = TASKFILE_NO_DATA;
rq->cmd_type = REQ_TYPE_ATA_TASKFILE;
- rq->cmd_flags |= REQ_SOFTBARRIER;
rq->special = task;
}
diff --git a/drivers/ide/ide-ioctls.c b/drivers/ide/ide-ioctls.c
index 1be263e..d440fbb 100644
--- a/drivers/ide/ide-ioctls.c
+++ b/drivers/ide/ide-ioctls.c
@@ -229,7 +229,6 @@ static int generic_drive_reset(ide_drive_t *drive)
rq->cmd_type = REQ_TYPE_SPECIAL;
rq->cmd_len = 1;
rq->cmd[0] = REQ_DRIVE_RESET;
- rq->cmd_flags |= REQ_SOFTBARRIER;
if (blk_execute_rq(drive->queue, NULL, rq, 1))
ret = rq->errors;
blk_put_request(rq);
--
1.6.0.2
next prev parent reply other threads:[~2009-03-13 5:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 5:02 [GIT PATCH] block: cleanup patches Tejun Heo
2009-03-13 5:02 ` [PATCH 01/14] block: merge blk_invoke_request_fn() into __blk_run_queue() Tejun Heo
2009-03-13 5:02 ` [PATCH 02/14] block: kill blk_start_queueing() Tejun Heo
2009-03-13 5:02 ` [PATCH 03/14] block: don't set REQ_NOMERGE unnecessarily Tejun Heo
2009-03-13 5:02 ` Tejun Heo [this message]
2009-03-13 5:02 ` [PATCH 05/14] block: clean up misc stuff after block layer timeout conversion Tejun Heo
2009-03-13 5:02 ` [PATCH 06/14] block: reorder request completion functions Tejun Heo
2009-03-13 5:02 ` [PATCH 07/14] block: reorganize request fetching functions Tejun Heo
2009-03-13 5:02 ` [PATCH 08/14] block: kill blk_end_request_callback() Tejun Heo
2009-03-13 5:02 ` [PATCH 09/14] block: clean up request completion API Tejun Heo
2009-03-16 9:12 ` Boaz Harrosh
2009-03-16 9:45 ` Tejun Heo
2009-03-13 5:02 ` [PATCH 10/14] block: move rq->start_time initialization to blk_rq_init() Tejun Heo
2009-03-13 5:02 ` [PATCH 11/14] block: implement and use [__]blk_end_request_all() Tejun Heo
2009-03-13 19:21 ` Bartlomiej Zolnierkiewicz
2009-03-14 1:56 ` Tejun Heo
2009-03-14 2:10 ` Tejun Heo
2009-03-14 19:23 ` Bartlomiej Zolnierkiewicz
2009-03-14 19:56 ` James Bottomley
2009-03-14 20:19 ` Bartlomiej Zolnierkiewicz
2009-03-15 16:48 ` Jens Axboe
2009-03-15 17:40 ` Bartlomiej Zolnierkiewicz
2009-03-15 18:39 ` Jens Axboe
2009-03-15 20:34 ` Bartlomiej Zolnierkiewicz
2009-03-15 20:48 ` Jens Axboe
2009-03-15 21:34 ` Bartlomiej Zolnierkiewicz
2009-03-16 1:39 ` Tejun Heo
2009-03-13 5:02 ` [PATCH 12/14] block: kill end_request() Tejun Heo
2009-03-13 5:02 ` [PATCH 13/14] ubd: simplify block request completion Tejun Heo
2009-03-13 5:02 ` [PATCH 14/14] block: clean up unnecessary stuff from block drivers Tejun Heo
2009-03-14 2:00 ` [GIT PATCH] block: cleanup patches Tejun Heo
2009-03-15 16:45 ` Jens Axboe
2009-03-16 1:15 ` Tejun Heo
2009-03-16 7:22 ` Jens Axboe
2009-03-16 7:53 ` Tejun Heo
2009-03-16 7:57 ` Jens Axboe
2009-04-21 16:37 [GIT PATCH linux-2.6-block] block: cleanup patches, take#3 Tejun Heo
2009-04-21 16:37 ` [PATCH 04/14] block: cleanup REQ_SOFTBARRIER usages Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236920578-2179-5-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome