From: Tejun Heo <tj@kernel.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/14] block: clean up request completion API
Date: Mon, 16 Mar 2009 18:45:28 +0900 [thread overview]
Message-ID: <49BE1FB8.6000505@kernel.org> (raw)
In-Reply-To: <49BE180A.7010904@panasas.com>
Boaz Harrosh wrote:
> I have a small request below, if it's OK?
Sure.
>
> + * Drivers that supports bidi can safely call this member for any type
> + * of request, bidi or uni. In the later case @bidi_bytes is just
> + * ignored.
>
> Please add some comment like above, the subject arose a few times before
> where programmers thought they need to do an if() and call this or above
> blk_end_request.
Comment added as suggested and patch description updated accordingly.
Git tree has been rebased. New commit ID is
5b437c316dcdb30598a73b03f529df89e880ac15.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-03-16 9:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 5:02 [GIT PATCH] block: cleanup patches Tejun Heo
2009-03-13 5:02 ` [PATCH 01/14] block: merge blk_invoke_request_fn() into __blk_run_queue() Tejun Heo
2009-03-13 5:02 ` [PATCH 02/14] block: kill blk_start_queueing() Tejun Heo
2009-03-13 5:02 ` [PATCH 03/14] block: don't set REQ_NOMERGE unnecessarily Tejun Heo
2009-03-13 5:02 ` [PATCH 04/14] block: cleanup REQ_SOFTBARRIER usages Tejun Heo
2009-03-13 5:02 ` [PATCH 05/14] block: clean up misc stuff after block layer timeout conversion Tejun Heo
2009-03-13 5:02 ` [PATCH 06/14] block: reorder request completion functions Tejun Heo
2009-03-13 5:02 ` [PATCH 07/14] block: reorganize request fetching functions Tejun Heo
2009-03-13 5:02 ` [PATCH 08/14] block: kill blk_end_request_callback() Tejun Heo
2009-03-13 5:02 ` [PATCH 09/14] block: clean up request completion API Tejun Heo
2009-03-16 9:12 ` Boaz Harrosh
2009-03-16 9:45 ` Tejun Heo [this message]
2009-03-13 5:02 ` [PATCH 10/14] block: move rq->start_time initialization to blk_rq_init() Tejun Heo
2009-03-13 5:02 ` [PATCH 11/14] block: implement and use [__]blk_end_request_all() Tejun Heo
2009-03-13 19:21 ` Bartlomiej Zolnierkiewicz
2009-03-14 1:56 ` Tejun Heo
2009-03-14 2:10 ` Tejun Heo
2009-03-14 19:23 ` Bartlomiej Zolnierkiewicz
2009-03-14 19:56 ` James Bottomley
2009-03-14 20:19 ` Bartlomiej Zolnierkiewicz
2009-03-15 16:48 ` Jens Axboe
2009-03-15 17:40 ` Bartlomiej Zolnierkiewicz
2009-03-15 18:39 ` Jens Axboe
2009-03-15 20:34 ` Bartlomiej Zolnierkiewicz
2009-03-15 20:48 ` Jens Axboe
2009-03-15 21:34 ` Bartlomiej Zolnierkiewicz
2009-03-16 1:39 ` Tejun Heo
2009-03-13 5:02 ` [PATCH 12/14] block: kill end_request() Tejun Heo
2009-03-13 5:02 ` [PATCH 13/14] ubd: simplify block request completion Tejun Heo
2009-03-13 5:02 ` [PATCH 14/14] block: clean up unnecessary stuff from block drivers Tejun Heo
2009-03-14 2:00 ` [GIT PATCH] block: cleanup patches Tejun Heo
2009-03-15 16:45 ` Jens Axboe
2009-03-16 1:15 ` Tejun Heo
2009-03-16 7:22 ` Jens Axboe
2009-03-16 7:53 ` Tejun Heo
2009-03-16 7:57 ` Jens Axboe
2009-04-21 16:37 [GIT PATCH linux-2.6-block] block: cleanup patches, take#3 Tejun Heo
2009-04-21 16:37 ` [PATCH 09/14] block: clean up request completion API Tejun Heo
2009-04-21 17:59 ` Christoph Hellwig
2009-04-23 1:24 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BE1FB8.6000505@kernel.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=bharrosh@panasas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome