From: Joerg Roedel <joerg.roedel@amd.com>
To: Avi Kivity <avi@redhat.com>
Cc: Alexander Graf <agraf@suse.de>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 06/12] kvm/svm: complete interrupts after handling nested exits
Date: Wed, 29 Jul 2009 14:56:26 +0200 [thread overview]
Message-ID: <1248872192-30881-7-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1248872192-30881-1-git-send-email-joerg.roedel@amd.com>
The interrupt completion code must run after nested exits are handled
because not injected interrupts or exceptions may be handled by the l1
guest first.
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
arch/x86/kvm/svm.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 0a0b3e1..1756a4c 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -118,6 +118,7 @@ static int nested = 0;
module_param(nested, int, S_IRUGO);
static void svm_flush_tlb(struct kvm_vcpu *vcpu);
+static void svm_complete_interrupts(struct vcpu_svm *svm);
static int nested_svm_exit_handled(struct vcpu_svm *svm, bool kvm_override);
static int nested_svm_vmexit(struct vcpu_svm *svm);
@@ -2329,6 +2330,8 @@ static int handle_exit(struct kvm_run *kvm_run, struct kvm_vcpu *vcpu)
}
}
+ svm_complete_interrupts(svm);
+
if (npt_enabled) {
int mmu_reload = 0;
if ((vcpu->arch.cr0 ^ svm->vmcb->save.cr0) & X86_CR0_PG) {
@@ -2695,8 +2698,6 @@ static void svm_vcpu_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
vcpu->arch.regs_avail &= ~(1 << VCPU_EXREG_PDPTR);
vcpu->arch.regs_dirty &= ~(1 << VCPU_EXREG_PDPTR);
}
-
- svm_complete_interrupts(svm);
}
#undef R
--
1.6.3.3
next prev parent reply other threads:[~2009-07-29 13:00 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 12:56 [PATCH 0/12] Nested SVM cleanups Joerg Roedel
2009-07-29 12:56 ` [PATCH 01/12] kvm/svm: make nested svm debugging runtime configurable Joerg Roedel
2009-07-29 13:22 ` Alexander Graf
2009-07-29 12:56 ` [PATCH 02/12] kvm/svm: add helper functions for global interrupt flag Joerg Roedel
2009-07-29 13:15 ` Alexander Graf
2009-07-29 13:44 ` Joerg Roedel
2009-07-29 12:56 ` [PATCH 03/12] kvm/svm: optimize nested #vmexit Joerg Roedel
2009-07-29 13:23 ` Alexander Graf
2009-07-29 12:56 ` [PATCH 04/12] kvm/svm: optimize nested vmrun Joerg Roedel
2009-07-29 13:27 ` Alexander Graf
2009-07-29 12:56 ` [PATCH 05/12] kvm/svm: copy only necessary parts of the control area on vmrun/vmexit Joerg Roedel
2009-07-29 13:30 ` Alexander Graf
2009-07-29 13:47 ` Joerg Roedel
2009-07-29 13:48 ` Alexander Graf
2009-07-29 12:56 ` Joerg Roedel [this message]
2009-07-29 13:46 ` [PATCH 06/12] kvm/svm: complete interrupts after handling nested exits Alexander Graf
2009-07-29 12:56 ` [PATCH 07/12] kvm/svm: move nested svm state into seperate struct Joerg Roedel
2009-07-29 13:49 ` Alexander Graf
2009-07-29 12:56 ` [PATCH 08/12] kvm/svm: cache nested intercepts Joerg Roedel
2009-07-29 13:13 ` Avi Kivity
2009-07-29 13:13 ` Joerg Roedel
2009-07-29 13:26 ` Avi Kivity
2009-07-29 13:47 ` Joerg Roedel
2009-07-29 13:50 ` Alexander Graf
2009-07-29 13:52 ` Joerg Roedel
2009-07-29 12:56 ` [PATCH 09/12] kvm/svm: consolidate nested_svm_exit_handled Joerg Roedel
2009-07-29 13:56 ` Alexander Graf
2009-07-29 12:56 ` [PATCH 10/12] kvm/svm: do nested vmexit in nested_svm_exit_handled Joerg Roedel
2009-07-29 14:15 ` Alexander Graf
2009-07-29 12:56 ` [PATCH 11/12] kvm/svm: handle #pf intercepts in nested_svm_exit_handled directly Joerg Roedel
2009-07-29 14:20 ` Alexander Graf
2009-07-29 14:44 ` Avi Kivity
2009-07-29 14:41 ` Alexander Graf
2009-07-29 14:49 ` Avi Kivity
2009-07-29 14:46 ` Alexander Graf
2009-07-29 12:56 ` [PATCH 12/12] kvm/svm: simplify nested_svm_check_exception Joerg Roedel
2009-07-29 14:21 ` Alexander Graf
2009-07-29 13:05 ` [PATCH 0/12] Nested SVM cleanups Avi Kivity
2009-07-29 13:09 ` Joerg Roedel
2009-07-29 13:31 ` Avi Kivity
2009-07-29 13:32 ` Avi Kivity
2009-07-29 13:29 ` Alexander Graf
2009-07-29 13:38 ` Joerg Roedel
2009-07-29 13:48 ` Avi Kivity
2009-07-29 13:48 ` Joerg Roedel
2009-07-29 13:59 ` Avi Kivity
2009-07-29 13:58 ` Joerg Roedel
2009-07-29 14:07 ` Avi Kivity
2009-07-29 13:06 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248872192-30881-7-git-send-email-joerg.roedel@amd.com \
--to=joerg.roedel@amd.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®