Re: [PATCH 02/12] kvm/svm: add helper functions for global interrupt flag

[Alexander Graf <agraf@suse.de>]

Joerg Roedel wrote:
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
>  arch/x86/kvm/svm.c |   31 +++++++++++++++++++++++--------
>  1 files changed, 23 insertions(+), 8 deletions(-)
>
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 27d26c3..9f69b25 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -136,6 +136,21 @@ static inline bool is_nested(struct vcpu_svm *svm)
>  	return svm->nested_vmcb;
>  }
>  
> +static inline void enable_gif(struct vcpu_svm *svm)
> +{
> +	svm->vcpu.arch.hflags |= HF_GIF_MASK;
> +}
> +
> +static inline void disable_gif(struct vcpu_svm *svm)
> +{
> +	svm->vcpu.arch.hflags &= ~HF_GIF_MASK;
> +}
> +
> +static inline bool gif_set(struct vcpu_svm *svm)
> +{
> +	return !!(svm->vcpu.arch.hflags & HF_GIF_MASK);
> +}
> +
>  static unsigned long iopm_base;
>  
>  struct kvm_ldttss_desc {
> @@ -630,7 +645,7 @@ static void init_vmcb(struct vcpu_svm *svm)
>  	force_new_asid(&svm->vcpu);
>  
>  	svm->nested_vmcb = 0;
> -	svm->vcpu.arch.hflags = HF_GIF_MASK;
> +	enable_gif(svm);
>   

Are we sure hflags is always 0 here?