[PATCH] Staging: dream: generic_gpio: Use linux instead of asm uaccess.h

[PATCH] Staging: dream: generic_gpio: Use linux instead of asm uaccess.h

[Chihau Chau]

From: Chihau Chau <chihau@gmail.com>

This is moving toward using <linux/uaccess.h> instead of the old
<asm/uaccess.h> file.

Signed-off-by: Chihau Chau <chihau@gmail.com>
---
 drivers/staging/dream/generic_gpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/dream/generic_gpio.c b/drivers/staging/dream/generic_gpio.c
index fe24d38..bf19b85 100644
--- a/drivers/staging/dream/generic_gpio.c
+++ b/drivers/staging/dream/generic_gpio.c
@@ -18,7 +18,7 @@
 #include <linux/errno.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
-#include <asm/gpio.h>
+#include <linux/gpio.h>
 #include "gpio_chip.h"
 
 #define GPIO_NUM_TO_CHIP_INDEX(gpio) ((gpio)>>5)
-- 
1.5.6.3

Re: [PATCH] Staging: dream: generic_gpio: Use linux instead of asm uaccess.h

[Pavel Machek]

On Mon 2010-03-15 00:05:55, Chihau Chau wrote:
> From: Chihau Chau <chihau@gmail.com>
> 
> This is moving toward using <linux/uaccess.h> instead of the old
> <asm/uaccess.h> file.

Changelog does not match the patch.

...plus, was the patch actually tested?
									Pavel

> --- a/drivers/staging/dream/generic_gpio.c
> +++ b/drivers/staging/dream/generic_gpio.c
> @@ -18,7 +18,7 @@
>  #include <linux/errno.h>
>  #include <linux/slab.h>
>  #include <linux/spinlock.h>
> -#include <asm/gpio.h>
> +#include <linux/gpio.h>
>  #include "gpio_chip.h"
>  
>  #define GPIO_NUM_TO_CHIP_INDEX(gpio) ((gpio)>>5)

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] Staging: dream: generic_gpio: Use linux instead of asm uaccess.h

[Chihau Chau]

Sorry I have been confused with the description of another patch.

I will fix the description.

Thanks Pavel!

2010/3/15 Pavel Machek <pavel@ucw.cz>:
> On Mon 2010-03-15 00:05:55, Chihau Chau wrote:
>> From: Chihau Chau <chihau@gmail.com>
>>
>> This is moving toward using <linux/uaccess.h> instead of the old
>> <asm/uaccess.h> file.
>
> Changelog does not match the patch.
>
> ...plus, was the patch actually tested?
>                                                                        Pavel
>
>> --- a/drivers/staging/dream/generic_gpio.c
>> +++ b/drivers/staging/dream/generic_gpio.c
>> @@ -18,7 +18,7 @@
>>  #include <linux/errno.h>
>>  #include <linux/slab.h>
>>  #include <linux/spinlock.h>
>> -#include <asm/gpio.h>
>> +#include <linux/gpio.h>
>>  #include "gpio_chip.h"
>>
>>  #define GPIO_NUM_TO_CHIP_INDEX(gpio) ((gpio)>>5)
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>



-- 
Chihau Chau

Re: [PATCH] Staging: dream: generic_gpio: Use linux instead of asm uaccess.h

[Pavel Machek]

Hi!

> Sorry I have been confused with the description of another patch.
> 
> I will fix the description.
> 
> Thanks Pavel!
...
> > ...plus, was the patch actually tested?

I'd still like to know if it was tested...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] Staging: dream: generic_gpio: Use linux instead of asm uaccess.h

[Chihau Chau]

No I don't know how to test it in my G1.

2010/3/15 Pavel Machek <pavel@ucw.cz>:
> Hi!
>
>> Sorry I have been confused with the description of another patch.
>>
>> I will fix the description.
>>
>> Thanks Pavel!
> ...
>> > ...plus, was the patch actually tested?
>
> I'd still like to know if it was tested...
>                                                                        Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>



-- 
Chihau Chau

Re: [PATCH] Staging: dream: generic_gpio: Use linux instead of asm uaccess.h

[Daniel Walker]

On Mon, 2010-03-15 at 06:33 +0100, Pavel Machek wrote:
> On Mon 2010-03-15 00:05:55, Chihau Chau wrote:
> > From: Chihau Chau <chihau@gmail.com>
> > 
> > This is moving toward using <linux/uaccess.h> instead of the old
> > <asm/uaccess.h> file.
> 
> Changelog does not match the patch.
> 
> ...plus, was the patch actually tested?
>                                                                         Pavel
> 
> > --- a/drivers/staging/dream/generic_gpio.c
> > +++ b/drivers/staging/dream/generic_gpio.c 

We need to do some sort of staging re-sync .. This file for instance
doesn't exist in the Google's tree any longer .. They moved to gpiolib,
although they still need cleanups on top of that.

Daniel

Re: [PATCH] Staging: dream: generic_gpio: Use linux instead of asm uaccess.h

[Pavel Machek]

On Mon 2010-03-15 15:09:51, Daniel Walker wrote:
> On Mon, 2010-03-15 at 06:33 +0100, Pavel Machek wrote:
> > On Mon 2010-03-15 00:05:55, Chihau Chau wrote:
> > > From: Chihau Chau <chihau@gmail.com>
> > > 
> > > This is moving toward using <linux/uaccess.h> instead of the old
> > > <asm/uaccess.h> file.
> > 
> > Changelog does not match the patch.
> > 
> > ...plus, was the patch actually tested?
> >                                                                         Pavel
> > 
> > > --- a/drivers/staging/dream/generic_gpio.c
> > > +++ b/drivers/staging/dream/generic_gpio.c 
> 
> We need to do some sort of staging re-sync .. This file for instance
> doesn't exist in the Google's tree any longer .. They moved to gpiolib,
> although they still need cleanups on top of that.

Yep. I hoped Google would just start using the stuff once it hit
staging, but...
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html