mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: florian@mickler.org
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
	linux-kernel@vger.kernel.org,
	Stephen Hemminger <shemminger@vyatta.com>,
	Florian Mickler <florian@mickler.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Joe Perches <joe@perches.com>
Subject: [PATCH] scripts/get_maintainer.pl: default to not include unspecified tags
Date: Tue, 11 May 2010 08:36:36 +0200	[thread overview]
Message-ID: <1273559797-6910-1-git-send-email-florian@mickler.org> (raw)
In-Reply-To: <30a2fd47565ff33d6f47d9a76746b56d923856ac.1273466698.git.joe@perches.com>

This changes the default of the option --git-all-signature-types to be
disabled by default.

The effect being, that only certain (currently  Signed-Off-By:,
Acked-By: and Reviewed-By:) tags are used to get adresses of potential
maintainers.

Motivated is this change by the desire to not 'spam' people unnecessary:
A Tested-By or a Reported-By is not ment as a hint that those people
want to/are able to review patches to the code in question.

In a quest to find resilient statistics for this i came up with this:

I produced a list of all the tag-signers not already covered
with a signed-off/acked/reviewed tag somewhere in the last year of git history.

Those were 650 addresses of "assumed non-developers".

And to check if those "assumed non-developers" are professional
testers/reporters worth cc'ing, i then counted their total appearences
in the git log:

469 were mentioned only once.
123 were mentioned twice.
38 three times
8 four times
5 six times
5 five times
1 eight times
1 fourteen times

I believe this supports my thesis, that the ''non-maintainer-tags'' are
not actively useful for patch-review. (except probably the guy
mentioned fourteen times...)

But of course one could also find arguments to poke holes in this
statistics, for example does this statistic not include code-locality:
A tested-by on a patch that touches some specific piece of
code can be more worth than a signed-off in another part of the tree.

But... let's play it safe and let's err on the "safe" side
meaning to not spam those people when in doubt. We already have the
signed-off's and Maintainers file. So this should be ok. And if need be, 
the maintainers can always forward the patch.

[i probably could make a diploma thesis out of this changelog :)]

Signed-off-by: Florian Mickler <florian@mickler.org>
---
 scripts/get_maintainer.pl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index b82ac95..b228198 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -25,7 +25,7 @@ my $email_list = 1;
 my $email_subscriber_list = 0;
 my $email_git_penguin_chiefs = 0;
 my $email_git = 1;
-my $email_git_all_signature_types = 1;
+my $email_git_all_signature_types = 0;
 my $email_git_blame = 0;
 my $email_git_min_signatures = 1;
 my $email_git_max_maintainers = 5;
-- 
1.7.0.4


  parent reply	other threads:[~2010-05-11  6:37 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-06  1:57 [PATCH] epoll: use wrapper functions Changli Gao
2010-05-06  6:00 ` indiscriminate get_maintainer.pl usage (was [PATCH] epoll: use wrapper functions) Stefan Richter
     [not found]   ` <s2t412e6f7f1005052319sdbf3fdfbg256d11b983c4f304@mail.gmail.com>
2010-05-06  6:40     ` indiscriminate get_maintainer.pl usage Stefan Richter
2010-05-06 15:42       ` Davide Libenzi
2010-05-06 16:52         ` Joe Perches
2010-05-06 17:59           ` Davide Libenzi
2010-05-06 20:52             ` Joe Perches
2010-05-07  6:34               ` [PATCH] get_maintainer.pl: ignore non-maintainer tags florian
2010-05-07  6:39                 ` Joe Perches
2010-05-07  7:02                   ` Florian Mickler
2010-05-07 19:48                     ` Stefan Richter
2010-05-08 21:32                       ` [PATCH] get_maintainer.pl: optionally " florian
2010-05-08 21:39                         ` [PATCH] [RFC] get_maintainer.pl: only list maintainers by default florian
2010-05-08 22:44                           ` Joe Perches
2010-05-08 23:23                             ` Stefan Richter
2010-05-08 23:51                               ` Joe Perches
2010-05-09  0:22                                 ` Stefan Richter
2010-05-09  0:57                                   ` Joe Perches
2010-05-09  8:18                                     ` Stefan Richter
2010-05-09  8:41                                       ` Stefan Richter
2010-05-09  8:49                                     ` Florian Mickler
2010-05-09  9:12                                     ` Stefan Richter
2010-05-09  8:40                             ` Florian Mickler
2010-05-08 22:06                         ` [PATCH] get_maintainer.pl: optionally ignore non-maintainer tags Joe Perches
2010-05-09  9:15                           ` [PATCH v2] " florian
2010-05-09  9:35                             ` Stefan Richter
2010-05-10  4:56                             ` [PATCH 0/2] scripts/get_maintainer.pl: trivial improvements Joe Perches
2010-05-10  4:56                               ` [PATCH 1/2] scripts/get_maintainer.pl: optionally ignore non-maintainer signatures Joe Perches
2010-05-10  5:07                                 ` Florian Mickler
2010-05-11  6:36                                 ` florian [this message]
2010-05-11  7:48                                   ` [PATCH] scripts/get_maintainer.pl: default to not include unspecified tags Wolfram Sang
2010-05-11 15:59                                   ` Joe Perches
2010-05-11 16:33                                     ` Florian Mickler
2010-05-11 16:40                                       ` Joe Perches
2010-05-10  4:56                               ` [PATCH 2/2] scripts/get_maintainer.pl: add .get_maintainer.conf default options file Joe Perches
2010-05-12  6:30                                 ` Américo Wang
2010-05-12  9:25                                   ` Florian Mickler
2010-05-13 15:58                                     ` Américo Wang
2010-05-13 16:22                                       ` Joe Perches
2010-05-08 22:26                         ` [PATCH] " Joe Perches
2010-05-09  9:12                           ` Florian Mickler
2010-05-06 20:13       ` indiscriminate get_maintainer.pl usage Roland Dreier
2010-05-06 18:47 ` [PATCH] epoll: use wrapper functions Davide Libenzi
2010-05-06 18:51   ` Peter Zijlstra
2010-05-07  2:48     ` Changli Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273559797-6910-1-git-send-email-florian@mickler.org \
    --to=florian@mickler.org \
    --cc=akpm@linux-foundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®