mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Florian Mickler <florian@mickler.org>
Cc: "Américo Wang" <xiyou.wangcong@gmail.com>,
	"Joe Perches" <joe@perches.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Stephen Hemminger" <shemminger@vyatta.com>,
	"Stefan Richter" <stefanr@s5r6.in-berlin.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] scripts/get_maintainer.pl: add .get_maintainer.conf default options file
Date: Thu, 13 May 2010 23:58:39 +0800	[thread overview]
Message-ID: <20100513155839.GE5132@cr0.redhat.com> (raw)
In-Reply-To: <20100512112549.650b321c@schatten.dmk.lab>

On Wed, May 12, 2010 at 11:25:49AM +0200, Florian Mickler wrote:
>On Wed, 12 May 2010 14:30:42 +0800
>Américo Wang <xiyou.wangcong@gmail.com> wrote:
>
>> On Sun, May 09, 2010 at 09:56:03PM -0700, Joe Perches wrote:
>> >Allow the use of a .get_maintainer.conf file to control the
>> >default options applied when scripts/get_maintainer.pl is run.
>> >
>> >.get_maintainer.conf can contain any valid command-line argument.
>> >
>> >File contents are prepended to any additional command line arguments.
>> >
>> >Multiple lines may be used, blank lines ignored, # is a comment.
>> 
>> Do we really have to do this? This looks odd to me.
>
>it's a little hackish, but the code impact is small. if you prefer
>standard config-file syntax (i.e. "bla=" ) check the patch below. 
>

Better somwhat, but...

>joe, what do you think?
>
>> If the user of get_maintainer.pl uses some long command line
>> arguments, to save his input, he should use bash aliases, not
>> configure files. I never see configure files used like this.
>
>bash aliases don't work (at least here) with "git send-email --cc-cmd="
>
...
>> 
>> Also, it doesn't worthy a configure file for such a script like
>> get_maintainer.pl.
>
>hm.. the only other way to use it via git send-email would be a wrapper
>script? 
>

I still think we should avoid config files as possible as we can.

Thanks.

  reply	other threads:[~2010-05-13 15:54 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-06  1:57 [PATCH] epoll: use wrapper functions Changli Gao
2010-05-06  6:00 ` indiscriminate get_maintainer.pl usage (was [PATCH] epoll: use wrapper functions) Stefan Richter
     [not found]   ` <s2t412e6f7f1005052319sdbf3fdfbg256d11b983c4f304@mail.gmail.com>
2010-05-06  6:40     ` indiscriminate get_maintainer.pl usage Stefan Richter
2010-05-06 15:42       ` Davide Libenzi
2010-05-06 16:52         ` Joe Perches
2010-05-06 17:59           ` Davide Libenzi
2010-05-06 20:52             ` Joe Perches
2010-05-07  6:34               ` [PATCH] get_maintainer.pl: ignore non-maintainer tags florian
2010-05-07  6:39                 ` Joe Perches
2010-05-07  7:02                   ` Florian Mickler
2010-05-07 19:48                     ` Stefan Richter
2010-05-08 21:32                       ` [PATCH] get_maintainer.pl: optionally " florian
2010-05-08 21:39                         ` [PATCH] [RFC] get_maintainer.pl: only list maintainers by default florian
2010-05-08 22:44                           ` Joe Perches
2010-05-08 23:23                             ` Stefan Richter
2010-05-08 23:51                               ` Joe Perches
2010-05-09  0:22                                 ` Stefan Richter
2010-05-09  0:57                                   ` Joe Perches
2010-05-09  8:18                                     ` Stefan Richter
2010-05-09  8:41                                       ` Stefan Richter
2010-05-09  8:49                                     ` Florian Mickler
2010-05-09  9:12                                     ` Stefan Richter
2010-05-09  8:40                             ` Florian Mickler
2010-05-08 22:06                         ` [PATCH] get_maintainer.pl: optionally ignore non-maintainer tags Joe Perches
2010-05-09  9:15                           ` [PATCH v2] " florian
2010-05-09  9:35                             ` Stefan Richter
2010-05-10  4:56                             ` [PATCH 0/2] scripts/get_maintainer.pl: trivial improvements Joe Perches
2010-05-10  4:56                               ` [PATCH 1/2] scripts/get_maintainer.pl: optionally ignore non-maintainer signatures Joe Perches
2010-05-10  5:07                                 ` Florian Mickler
2010-05-11  6:36                                 ` [PATCH] scripts/get_maintainer.pl: default to not include unspecified tags florian
2010-05-11  7:48                                   ` Wolfram Sang
2010-05-11 15:59                                   ` Joe Perches
2010-05-11 16:33                                     ` Florian Mickler
2010-05-11 16:40                                       ` Joe Perches
2010-05-10  4:56                               ` [PATCH 2/2] scripts/get_maintainer.pl: add .get_maintainer.conf default options file Joe Perches
2010-05-12  6:30                                 ` Américo Wang
2010-05-12  9:25                                   ` Florian Mickler
2010-05-13 15:58                                     ` Américo Wang [this message]
2010-05-13 16:22                                       ` Joe Perches
2010-05-08 22:26                         ` [PATCH] " Joe Perches
2010-05-09  9:12                           ` Florian Mickler
2010-05-06 20:13       ` indiscriminate get_maintainer.pl usage Roland Dreier
2010-05-06 18:47 ` [PATCH] epoll: use wrapper functions Davide Libenzi
2010-05-06 18:51   ` Peter Zijlstra
2010-05-07  2:48     ` Changli Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100513155839.GE5132@cr0.redhat.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=florian@mickler.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome