mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
	kgdb-bugreport@lists.sourceforge.net,
	Jason Wessel <jason.wessel@windriver.com>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 12/17] ftrace,kdb: Allow dumping a specific cpu's buffer with ftdump
Date: Thu,  5 Aug 2010 09:37:53 -0500	[thread overview]
Message-ID: <1281019078-6636-13-git-send-email-jason.wessel@windriver.com> (raw)
In-Reply-To: <1281019078-6636-12-git-send-email-jason.wessel@windriver.com>

In systems with more than one processor it is desirable to look at the
per cpu trace buffers.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
CC: Frederic Weisbecker <fweisbec@gmail.com>
---
 kernel/trace/trace_kdb.c |   37 +++++++++++++++++++++++++++----------
 1 files changed, 27 insertions(+), 10 deletions(-)

diff --git a/kernel/trace/trace_kdb.c b/kernel/trace/trace_kdb.c
index 44cbda2..7b8ecd7 100644
--- a/kernel/trace/trace_kdb.c
+++ b/kernel/trace/trace_kdb.c
@@ -17,7 +17,7 @@
 #include "trace.h"
 #include "trace_output.h"
 
-static void ftrace_dump_buf(int skip_lines)
+static void ftrace_dump_buf(int skip_lines, long cpu_file)
 {
 	/* use static because iter can be a bit big for the stack */
 	static struct trace_iterator iter;
@@ -44,13 +44,20 @@ static void ftrace_dump_buf(int skip_lines)
 	iter.iter_flags |= TRACE_FILE_LAT_FMT;
 	iter.pos = -1;
 
-	for_each_tracing_cpu(cpu) {
-		iter.buffer_iter[cpu] =
+	if (cpu_file == TRACE_PIPE_ALL_CPU) {
+		for_each_tracing_cpu(cpu) {
+			iter.buffer_iter[cpu] =
 			ring_buffer_read_prepare(iter.tr->buffer, cpu);
-		ring_buffer_read_start(iter.buffer_iter[cpu]);
-		tracing_iter_reset(&iter, cpu);
+			ring_buffer_read_start(iter.buffer_iter[cpu]);
+			tracing_iter_reset(&iter, cpu);
+		}
+	} else {
+		iter.cpu_file = cpu_file;
+		iter.buffer_iter[cpu_file] =
+			ring_buffer_read_prepare(iter.tr->buffer, cpu_file);
+		ring_buffer_read_start(iter.buffer_iter[cpu_file]);
+		tracing_iter_reset(&iter, cpu_file);
 	}
-
 	if (!trace_empty(&iter))
 		trace_find_next_entry_inc(&iter);
 	while (!trace_empty(&iter)) {
@@ -91,9 +98,10 @@ out:
 static int kdb_ftdump(int argc, const char **argv)
 {
 	int skip_lines = 0;
+	long cpu_file;
 	char *cp;
 
-	if (argc > 1)
+	if (argc > 2)
 		return KDB_ARGCOUNT;
 
 	if (argc) {
@@ -102,8 +110,17 @@ static int kdb_ftdump(int argc, const char **argv)
 			skip_lines = 0;
 	}
 
+	if (argc == 2) {
+		cpu_file = simple_strtol(argv[2], &cp, 0);
+		if (*cp || cpu_file >= NR_CPUS || cpu_file < 0 ||
+		    !cpu_online(cpu_file))
+			return KDB_BADINT;
+	} else {
+		cpu_file = TRACE_PIPE_ALL_CPU;
+	}
+
 	kdb_trap_printk++;
-	ftrace_dump_buf(skip_lines);
+	ftrace_dump_buf(skip_lines, cpu_file);
 	kdb_trap_printk--;
 
 	return 0;
@@ -111,8 +128,8 @@ static int kdb_ftdump(int argc, const char **argv)
 
 static __init int kdb_ftrace_register(void)
 {
-	kdb_register_repeat("ftdump", kdb_ftdump, "", "Dump ftrace log",
-			    0, KDB_REPEAT_NONE);
+	kdb_register_repeat("ftdump", kdb_ftdump, "[skip_#lines] [cpu]",
+			    "Dump ftrace log", 0, KDB_REPEAT_NONE);
 	return 0;
 }
 
-- 
1.6.3.3


  reply	other threads:[~2010-08-05 14:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-05 14:37 [GIT PULL] kgdb,kdb for 2.6.36 (1 of 2) Jason Wessel
2010-08-05 14:37 ` [PATCH 01/17] kgdb: remove custom hex_to_bin()implementation Jason Wessel
2010-08-05 14:37   ` [PATCH 02/17] gdbstub: Optimize kgdb's "thread:" response for the gdb serial protocol Jason Wessel
2010-08-05 14:37     ` [PATCH 03/17] kgdb,kdb: individual register set and and get API Jason Wessel
2010-08-05 14:37       ` [PATCH 04/17] kgdb,x86: Individual register get/set for x86 Jason Wessel
2010-08-05 14:37         ` [PATCH 05/17] kgdb,mips: Individual register get/set for mips Jason Wessel
2010-08-05 14:37           ` [PATCH 06/17] kgdb,arm: Individual register get/set for arm Jason Wessel
2010-08-05 14:37             ` [PATCH 07/17] gdbstub: Implement gdbserial 'p' and 'P' packets Jason Wessel
2010-08-05 14:37               ` [PATCH 08/17] gdbstub: do not directly use dbg_reg_def[] in gdb_cmd_reg_set() Jason Wessel
2010-08-05 14:37                 ` [PATCH 09/17] arm,kgdb: Add ability to trap into debugger on notify_die Jason Wessel
2010-08-05 14:37                   ` [PATCH 10/17] kgdb,powerpc: Replace hardcoded offset by BREAK_INSTR_SIZE Jason Wessel
2010-08-05 14:37                     ` [PATCH 11/17] ftrace,kdb: Extend kdb to be able to dump the ftrace buffer Jason Wessel
2010-08-05 14:37                       ` Jason Wessel [this message]
2010-08-05 14:37                         ` [PATCH 13/17] KGDB: Remove set but unused newPC Jason Wessel
2010-08-05 14:37                           ` [PATCH 14/17] mm,kdb,kgdb: Add a debug reference for the kdb kmap usage Jason Wessel
2010-08-05 14:37                             ` [PATCH 15/17] kgdb,mips: remove unused kgdb_cpu_doing_single_step operations Jason Wessel
2010-08-05 14:37                               ` [PATCH 16/17] kgdb,x86: use macro HBP_NUM to replace magic number 4 Jason Wessel
2010-08-05 14:37                                 ` [PATCH 17/17] debug_core,kdb: fix crash when arch does not have single step Jason Wessel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281019078-6636-13-git-send-email-jason.wessel@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=fweisbec@gmail.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®